Skip to content
This repository was archived by the owner on Jan 5, 2025. It is now read-only.

Conversation

@ticevi
Copy link
Contributor

@ticevi ticevi commented Nov 3, 2020

adds new v6 tag to run dhcpv6 server in Docker
#20

@robinsmidsrod
Copy link
Contributor

@ticevi I would suggest implementing this using an environment variable instead, so that the same entrypoint can run either IPv4 (default) or IPv6. Then you won't have so much duplication of code, following the DRY principle.

@ticevi
Copy link
Contributor Author

ticevi commented Nov 5, 2020

@robinsmidsrod good point. I have adapted my merge request

@robinsmidsrod
Copy link
Contributor

@ticevi Good direction! Can you change it even further, so that it uses -e DHCPD_PROTOCOL=6 (with value 4 being the default) to make the choice, and just have a single run line in entrypoint so that this environment variable generates a -4 or -6 argument to the final run command?

@robinsmidsrod robinsmidsrod merged commit 2ca8dcf into networkboot:master Nov 5, 2020
@robinsmidsrod robinsmidsrod mentioned this pull request Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants