This repository was archived by the owner on Jan 20, 2024. It is now read-only.
New refresh tokens given old key #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(revoked) refresh tokens. References issue #215
Contributor
|
@miklish I have switched back to master branch. The JDK11 branch will be removed. Thanks. |
Contributor
|
For people like me have hard time understanding how the system works before. @miklish has explained here. The defect is buried very deep. @miklish Good catch!!! |
stevehu
approved these changes
Dec 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New refresh tokens are now keyed by their token string, rather than the token string of the old refresh token in the request. This fix prevents refresh tokens from being re-used. Old refresh tokens are now properly revoked fter a single use.
References issue #215