refactor socket/netcode_conn add more of server implementation#18
Merged
gafferongames merged 4 commits intomas-bandwidth:masterfrom Apr 11, 2017
Merged
refactor socket/netcode_conn add more of server implementation#18gafferongames merged 4 commits intomas-bandwidth:masterfrom
gafferongames merged 4 commits intomas-bandwidth:masterfrom
Conversation
Contributor
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Largest changes are around socket handling. Since the Read call is blocking in Go and we can't safely create a packet queue for server connections (since that would introduce a super simple DoS). I rewrote the connection handling code to call a delegate handler which servers/clients can set to process packets and do their internal packet queuing safely after verification.