[Rust] Fixed a bug where new clients are only accepted in first 5 seconds#36
Merged
gafferongames merged 2 commits intomas-bandwidth:masterfrom May 24, 2017
Merged
Conversation
…to be accepted after the first 5 seconds of the server running
Contributor
|
Awesome. Thanks! |
Contributor
|
ps. This is a real gotcha. I had the exact same error in my C implementation, which is unrelated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where new clients were only able to be accepted by the server within the first 5 seconds of the server starting.
After the server had been running for 5 seconds, any new connections were immediately timed out before the connection could be accepted.
I also exposed
token::DecodeErrorso that failed attempts to decode the ConnectToken can be handled more gracefully by the calling code.