Fixes #46: Buffer.GetBytes could cause panics#47
Merged
gafferongames merged 1 commit intomas-bandwidth:masterfrom Aug 14, 2017
toqueteos:master
Merged
Fixes #46: Buffer.GetBytes could cause panics#47gafferongames merged 1 commit intomas-bandwidth:masterfrom toqueteos:master
gafferongames merged 1 commit intomas-bandwidth:masterfrom
toqueteos:master
Conversation
Contributor
Author
Contributor
Author
|
Maybe instead of erroring out we should return all the remaining bytes and an error Another option is following |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
Buffer.GetBytesonly checks that the input size is less than the total buffer size so if we are near the end of the buffer and we ask for more bytes than there are left but still less than the total buffer size it'll panic.Example: suppose we have a buffer
bof size 4. If we do two calls tob.GetBytes(3), the second one will panic because we are asking for the last byte and two more.I've also removed some unnecessary endlines in
buffer_test.goEDIT: Added a longer explanation here.