replacing server & client sockets with socket_holder containing ipv4 & ipv6 sockets#60
Merged
gafferongames merged 3 commits intomas-bandwidth:masterfrom Feb 17, 2018
Conversation
…& ipv6 sockets changing server_create_overload memset to use vars instead of struct type w/o keyword
774582e to
ddaba86
Compare
Contributor
|
This looks awesome, but can you debug why the test is crashing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functionality:
netcode_client/server_create_internalwill create both 1 ipv4 & 1 ipv6 sockets. Client & Server dynamically select correct socket.Change Log:
netcode_client/server_create_overloadallows binding of 1 ipv4 & 1 ipv6 socket based on passed address.toorfromaddress to dynamically select the socket matching the address protocol.=======
netcode_client_tsocket was encapsulated innetcode_socket_holder_t<- contains 2 socketsnetcode_socket_create->netcode_socket_create_internal(renamed)test_client_createtest_server_createtest_client_server_ipv4_socket_connecttest_client_server_ipv6_socket_connectInternal Functionality Tests:
Cases:
a. ipv4 client <-> ipv4 address <-> ipv4 server
b. ipv6 client <-> ipv6 address <-> ipv6 server
c. ipv4/6 client <-> ipv4 address <-> ipv4/6 server
d. ipv4/6 client <-> ipv6 address <-> ipv6 server
e. ipv4/6 client <-> ipv4 address <-> ipv4 server
f. ipv6 client <-> ipv6 address <-> ipv4/6 server