Fix netcode server to update address property when letting the system assign a port.#94
Merged
gafferongames merged 2 commits intomas-bandwidth:masterfrom Mar 24, 2020
NormalVR:bugfix/system-assigned-port
Merged
Fix netcode server to update address property when letting the system assign a port.#94gafferongames merged 2 commits intomas-bandwidth:masterfrom NormalVR:bugfix/system-assigned-port
gafferongames merged 2 commits intomas-bandwidth:masterfrom
NormalVR:bugfix/system-assigned-port
Conversation
… assign a port. Update client_server.c example to use system-assigned port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, if you let the system assign a port (by passing port 0), the
server->addressproperty will have a port of 0 even after the system has assigned one. This means all incoming connection requests will be rejected because the port does not match.This PR updates the
server->addressproperty to include the system assigned port once the socket is created. Fixes issue #93.