Skip to content

Refactor proposal #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2021
Merged

Refactor proposal #1

merged 1 commit into from
Nov 19, 2021

Conversation

@chadell
Copy link
Contributor

@chadell chadell commented Nov 19, 2021

Please, review this proposal of refactor before jumping into the tests.

New style:

netcompare_check = CheckType.init(check_type_info, options)
pre_result = netcompare_check.extract_value_from_json_path(pre_obj, path)
post_result = netcompare_check.extract_value_from_json_path(post_obj, path)
netcompare_check.evaluate(pre_result, post_result)

lvrfrc87
lvrfrc87 reviewed Nov 19, 2021
View reviewed changes
@lvrfrc87
Copy link
Collaborator

lvrfrc87 commented Nov 19, 2021

LGTM! I will now merge so I can start to work on refactoring. In case someone has to add more, can do it later I would say

@lvrfrc87 lvrfrc87 merged commit 3671f07 into main Nov 19, 2021
@lvrfrc87 lvrfrc87 deleted the library-api branch November 19, 2021 09:14
lvrfrc87 added a commit that referenced this pull request Jun 13, 2023
@lvrfrc87
Merge pull request #1 from networktocode-llc/v.0.1.0
0d13ce9 
v. 0.1.0-beta release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lvrfrc87 lvrfrc87 lvrfrc87 approved these changes

@grelleum grelleum Awaiting requested review from grelleum

@jeffkala jeffkala Awaiting requested review from jeffkala jeffkala is a code owner

@pke11y pke11y Awaiting requested review from pke11y

@pszulczewski pszulczewski Awaiting requested review from pszulczewski pszulczewski is a code owner

@scetron scetron Awaiting requested review from scetron scetron is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chadell @lvrfrc87