Next round of refactor + typing fixes. #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pszulczewski
requested review from
chadell,
grelleum,
jeffkala,
lvrfrc87,
pke11y and
scetron
as code owners
Collaborator
|
Think it'd be a solid idea to agree upon the docstyle that will be used. |
Collaborator
Author
In other libraries I see we use google docstyle. I added some proposals. |
pszulczewski
force-pushed
the
refactor_typing_fixes
branch
from
7575b99 to
116f22b
Compare
chadell
reviewed
Dec 14, 2021
Collaborator
|
I believe should be merged after #10 |
pszulczewski
force-pushed
the
refactor_typing_fixes
branch
2 times, most recently
from
2064ccc to
1c6511a
Compare
pszulczewski
force-pushed
the
refactor_typing_fixes
branch
4 times, most recently
from
6f5fe2d to
872a72d
Compare
pszulczewski
force-pushed
the
refactor_typing_fixes
branch
from
872a72d to
3007383
Compare
lvrfrc87
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple fixes to typing.
refactor to
runner.extract_values_from_output()Initial, please review and add suggestions if there is anything else worth to improve.