-
Notifications
You must be signed in to change notification settings - Fork 6
Create utils for library refactoring #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chadell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not strong opinion, but I would simplify to netcompare/utils/ instead of an extra nested package for each group of functions.
Same for tests, I usually prefer to put all tests together, even in subfolders:
tests/check_type.py & tests/utils/check_refkey.py ...
utils for library refactoring
utils for library refactoring
chadell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good one. just some naming "suggestions"
|
@grelleum I am doing some refactoring in the code. I have managed to make all the test work apart the nested list implementation. Is something I can look at tomorrow but I was wondering if you can spare 10 minutes on it as you can quickly spot the issue and speedup the work. @chadell considering there is some work to do in matters of comments and doc string, would you mind to have a fresh look at this PR?? |
|
@grelleum Nevermind, I fixed :) |
pszulczewski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs improvements mainly in type hints.
|
I will go ahead and merge this PR so we can use an updated version of |
As part of refactoring, this is the first of a long PR series to make the code more readable.
All the utilities functions are now migrated under
utilsfolder. Test are also added for each singleutils.Var and functions are also renamed and comment lines are also added.
More refactoring is needed as for example possible implementation for utilities under a single class, as well as improve the overall library logic. Those will follow after this PR as I first need to make the code more readable and have all the tests in place