[WIP]: Data normalization as a default argument. Proposal to fix issue #13 #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pszulczewski
requested review from
jeffkala,
pke11y and
scetron
as code owners
pszulczewski
added
question
pszulczewski
changed the title
Collaborator
Author
|
Talked to Federico and agreed that we fix that in code without default arguments. When data structure is a list of dicts, then we skip fixing keys. Will submit it under another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I closed issue #13 because we expect normalized data for checks. However I still think we may have some corner cases where we may want to skip fixing keys. This is just a proposal how to give users more control on what data they would like to work with.
If you don't like it and you want to stick to only normalized data I am fine.
Let me know in comments what do you think?