Base class CheckType implemented as abstract class #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pszulczewski
commented
Feb 8, 2022
| [ | ||
| ("exact_match", ExactMatchType), | ||
| ("tolerance", ToleranceType), | ||
| ("parameter_match", ParameterMatchType), |
Collaborator
Author
There was a problem hiding this comment.
Parameter and regex were missing here.
|
|
||
| def evaluate(self, value_to_compare: Any, **kwargs) -> Tuple[Dict, bool]: | ||
| @abstractmethod | ||
| def evaluate(self, *args, **kwargs) -> Tuple[Dict, bool]: |
Collaborator
Author
There was a problem hiding this comment.
Changed that to be more generic, so code validation doesn't highlight it as method signature discrepancy in child classes.
pszulczewski
requested review from
grelleum,
jeffkala,
lvrfrc87,
pke11y and
scetron
as code owners
lvrfrc87
approved these changes
Feb 10, 2022
Collaborator
lvrfrc87
left a comment
lvrfrc87
left a comment
There was a problem hiding this comment.
Good one! That should overcome the concern we had about the implementation of those methods from future contributors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to implement
CheckTypeas abstract class and makevalidate()&evaluate()abstract methods.This ensures that every child CheckType must have
validate()&evaluate()methods implemented.Tests show that
TypeErrorexception is raised when an object is instantiated for a child class withoutvalidate()&evaluate()methods implemented.