Strip inner boolean from operator check
#55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure about this...if you look at the if statements, your suggestion would brake the logic...or am I missing something? Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
lvrfrc87
requested review from
chadell,
grelleum,
jeffkala,
pke11y,
pszulczewski and
scetron
as code owners
pszulczewski
requested changes
Apr 20, 2022
netcompare/check_types.py
Outdated
| # For naming consistency | ||
| # For name consistency. | ||
| reference_data = params | ||
| evaluation_result = operator_evaluator(reference_data["params"], value_to_compare) |
Collaborator
There was a problem hiding this comment.
Suggested change
| evaluation_result = operator_evaluator(reference_data["params"], value_to_compare) | |
| return operator_evaluator(reference_data["params"], value_to_compare) |
Collaborator
There was a problem hiding this comment.
operator_evaluator in evaluators.py typing should be changed from -> Dict to -> Tuple[List, bool]
netcompare/check_types.py
Outdated
| reference_data = params | ||
| evaluation_result = operator_evaluator(reference_data["params"], value_to_compare) | ||
| return evaluation_result, not evaluation_result | ||
| return evaluation_result[1], not evaluation_result[0] |
Collaborator
There was a problem hiding this comment.
Suggested change
| return evaluation_result[1], not evaluation_result[0] |
Not needed, bool should be second tuple item as in other checks.
Looks like we should change the order in Operator implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix https://github.com/networktocode-llc/netcompare/issues/54