Skip to content

initial at running config mapper updates #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2025
Merged

initial at running config mapper updates #704

merged 3 commits into from
Oct 20, 2025

Conversation

@jeffkala
Copy link
Collaborator

This was referenced Sep 10, 2025
Closed
Open
itdependsnetworks
itdependsnetworks reviewed Sep 12, 2025
View reviewed changes
itdependsnetworks
itdependsnetworks reviewed Sep 12, 2025
View reviewed changes
netutils/lib_mapper.py Outdated
"mikrotik_routeros": "/export",
"nokia_srl": "info",
"nokia_sros": "admin display-config",
"paloalto_panos": "show config running",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like people most often want:

> set cli config-output-format set
> configure 
Entering configuration mode
[edit]                                                                                                                                                                 
# show

Not that we can easily express that here, but worth a convo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think once you're doing this our stance should be to do a custom dispatcher.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it.. we should allow this, but adjust it in nornir-nautobot to account for it

@itdependsnetworks itdependsnetworks marked this pull request as ready for review October 20, 2025 01:55
@itdependsnetworks
Copy link
Contributor

removed these:

    "f5_tmsh": "show /",
    "huawei_huawei_vrpv8": "display current-configuration",
    "paloalto_panos": "show config running",

can revisit, but let's just move this forward.

@itdependsnetworks itdependsnetworks merged commit ac2ef03 into develop Oct 20, 2025
19 checks passed
@itdependsnetworks itdependsnetworks mentioned this pull request Oct 21, 2025
Merged
@itdependsnetworks itdependsnetworks deleted the jlk-config-commands branch October 21, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itdependsnetworks itdependsnetworks itdependsnetworks approved these changes

@qduk qduk Awaiting requested review from qduk qduk is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeffkala @itdependsnetworks