fix: correctly handle salt=0 in encrypt_cisco_type7
#742
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieu-mp
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
mathieu-mp
force-pushed
the
issue/741
branch
from
4feca77 to
4eb9419
Compare
The function `encrypt_cisco_type7` was incorrectly handling the integer `0` as a missing argument because of the thruthiness check (`if not salt:`). This resulted in a random salt being used when the user explicitely requested salt `0`. The condition has been updated to `if salt is None` to differentiate between a provided `0` and the default `None`.
Contributor
|
seems reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
encrypt_cisco_type7was incorrectly handling the integer0as a missing argument because of the thruthiness check (if not salt:). This resulted in a random salt being used when the user explicitely requested salt0.The condition has been updated to
if salt is Noneto differentiate between a provided0and the defaultNone.Fixes #741