Conversation
…t a reboot argument on set_boot_options
gsnider2195
requested review from
jeffkala,
pke11y and
pszulczewski
as code owners
jeffkala
reviewed
Apr 28, 2026
Comment on lines
+930
to
+932
| if not reboot: | ||
| log.info("Host %s: OS image %s boot options set. Reboot the device to apply", self.host, image_name) | ||
| return True |
Contributor
There was a problem hiding this comment.
Feel like for ios we need more logic. If install_mode is used the reboot automatically happens.
Contributor
Author
There was a problem hiding this comment.
We could copy what we're doing in iosxewlc and fail if the user selects install mode and reboot=False
jeffkala
approved these changes
Apr 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required vendoring pynxos and adding the reboot flag support to that dependency. Long term plan is to retire the pynxos package and remove it from this project after migrating all nxos commands to Netmiko.