Training oct28 take 2

[robin-stefani]

Added new Introduction to Solution courses, adjusted LPs accordingly. Also fixed a few typos and 1k course lengths.
Added new 1Secure core presales demo course.
Added 2 new LTT courses for partners: Threat Manager MCP and NDC v5.7.10

[claude]

PR Review: Training Content Updates (Oct 28)

Overview

This PR adds new training courses and learning paths, updates course durations, and fixes various typos across the training documentation. The changes are well-structured and follow the established patterns in the codebase.

Code Quality & Best Practices ✅

Strengths:

• Consistent use of React component imports across all files
• Follows the established module pattern for training content (index.js exports)
• Proper frontmatter metadata in all new .md files
• Maintains consistency with existing course numbering scheme (e.g., 1980-1985, 3600.6, 5600.1)
• Good use of JSX components for dynamic content (e.g., <Company />, <N1S />)

Recommendations:

• All new files follow existing conventions correctly
• The modular approach using imports is maintainable and promotes reusability

Potential Issues 🐛

Found Issues:

1. Typo in /src/training/privileged-access-management/1985.md:7

   The Introduction to <Company /> Privileged Access Management Solution course propresents the value of this solution.

   Should be: "presents" not "propresents"

2. Duplicate entry removed (Fixed in commit afcffb3)

   • The duplicate "Learn About Netwrix Password Reset" entry in docs/customer/training/learn-about/index.md was correctly removed ✅

Performance Considerations ⚡

Assessment: No concerns

• All changes are documentation/content only
• No build configuration changes that would impact performance
• New imports follow existing patterns and won't affect bundle size
• Static content generation remains efficient

Security Concerns 🔒

Assessment: No security issues

• All changes are training documentation content
• No executable code changes
• No sensitive data exposed
• No external dependencies added
• Imports are from internal modules only

Test Coverage 🧪

Considerations:

• These are content changes to training documentation
• Manual testing should verify:
  • All new learning path pages render correctly
  • All component imports resolve properly
  • Course duration calculations are accurate
  • Links in index pages work correctly
  • New presales certification page displays properly

Suggested Manual Tests:

# Test specific products mentioned in PR
DOCS_PRODUCT="1secure" npm run build
npm run start

Then verify:

• /docs/customer/training/learn-about/1secure.md shows updated duration (1.5 hours)
• /docs/partner/presales/1secure-core.md renders correctly
• All new intro courses (1980-1985) display properly
• Component imports work without errors

Content Review 📝

Positive aspects:

• Course durations updated from "5 minutes" to more realistic "2 minutes" consistently
• New introduction courses (1980-1985) provide consistent 1-minute overviews
• Learning path durations updated to reflect new content
• Good reorganization of presales/sales learning path categories
• Fixed typo "ceritifcation" → "certification" in presales index

Organizational improvements:

• Moved Platform Governance products from "Additional Products" to "Identity Management Solution" (better categorization)
• Added new Endpoint Management Solution sales learning path
• Consolidated related training materials logically

Summary

Overall Assessment: Excellent ✨

This is a well-executed content update that:

• Adds valuable new training materials
• Improves content organization
• Fixes several typos and inconsistencies
• Maintains code quality and consistency

Action Items:

• Fix typo in /src/training/privileged-access-management/1985.md:7 (propresents → presents)
• Manual verification of new pages rendering correctly
• Verify all learning path duration calculations are accurate

Recommendation: Approve with minor fix 🚀

Great work on this comprehensive training content update! Once the typo is fixed, this is ready to merge.

---

Review generated with assistance from Claude Code

[claude]

Pull Request Review: Training oct28 take 2

Overview

This PR adds several new training courses and solution introductions, updates course durations, and fixes various typos and organizational issues. Overall, the changes are well-structured and follow the repository's patterns.

✅ Strengths

1. Consistent Structure

• All new course files follow the established pattern with imports, headers, prerequisites, descriptions, and estimated lengths
• New solution introduction files (1980-1985) maintain consistent formatting
• Index.js exports are properly configured for all new modules

2. Comprehensive Updates

• Added 6 new solution introduction courses (DSPM, DM, EM, IM, ITDR, PAM)
• Added new 1Secure courses (3600.6 Alerts & Risk Assessment, 5600.1 Demo)
• Updated course durations across multiple products for accuracy
• Added new presales learning path for 1Secure Core

3. Proper Import/Export Management

• All new components are properly exported from their respective index.js files
• Import statements in consuming files correctly reference the new exports
• Component naming follows established conventions (e.g., DSPMIntro, ITDRIntro)

🔍 Observations & Minor Issues

1. Typo Fix ✅

• Line 6 in docs/partner/presales/index.md: Fixed "ceritifcation" → "certification"

2. Course Duration Standardization ✅

• Updated multiple "5 minutes" courses to "2 minutes" for consistency
• This appears intentional and improves accuracy across the training catalog

3. List Organization ✅

• Removed duplicate "Password Reset" entry in docs/customer/training/learn-about/index.md:25
• Reorganized product categories in sales/presales learning paths, moving Platform Governance products under Identity Management (more logical grouping)

4. Documentation Completeness

The PR description mentions:

"Added 2 new LTT courses for partners: Threat Manager MCP and NDC v5.7.10"

I can verify:

• ✅ "New MCP Server for Threat Manager" appears in src/training/threat-manager/additional.md:13
• ✅ "What's New in NDC 5.7.10" appears in src/training/data-classification/additional.md:7

Both courses are properly listed in the additional courses sections.

🎯 Best Practices Compliance

Code Quality ✅

• No hardcoded strings; all product names use component references (<Company />, <N1S />, etc.)
• Markdown frontmatter properly structured with required fields
• Consistent use of estimated time format

File Organization ✅

• New files placed in appropriate directories
• Sidebar positions logically ordered (1340 for new presales path)
• Version-agnostic approach maintained

Import Patterns ✅

• All imports use @site/src/training/* pattern consistently
• No circular dependencies detected
• Proper component destructuring in import statements

🔒 Security & Performance

No Security Concerns ✅

• No sensitive data exposure
• No external script inclusions
• All content is static documentation

Performance Considerations ✅

• Minimal impact - only adding documentation pages
• Component lazy-loading maintained through existing architecture
• No large media files added

📊 Test Coverage

Manual Testing Recommended

While the code structure looks correct, I recommend testing:

1. Build verification:

   npm run build

   Verify all new imports resolve correctly

2. Navigation testing:

   • Verify new 1Secure Core presales path renders correctly
   • Check all solution introduction courses appear in their respective learning paths
   • Test breadcrumb navigation on new pages

3. Component rendering:

   • Verify <Company />, <N1S />, and other product components render properly
   • Check that all imported course modules display content correctly

🎨 Documentation Quality

Consistency ✅

• Course descriptions follow established patterns
• Prerequisites properly specified
• Estimated lengths realistic and consistent

Completeness ✅

• All learning paths updated with new courses
• Index files updated to include new paths
• Additional courses sections maintained

📝 Suggestions (Optional)

Minor Recommendations:

1. Consider adding a changelog entry if the project maintains one, documenting the new courses added

2. Verify LMS integration (if applicable) - ensure the new course IDs (1980-1985, 3600.6, 5600.1) are properly registered in any external learning management system

3. Review course ordering - In the new 1Secure Core presales path, courses are listed logically, but verify this matches the intended learning progression

🎉 Conclusion

Recommendation: APPROVE ✅

This is a well-executed PR that:

• Adds valuable new training content
• Maintains code quality and consistency
• Follows repository conventions
• Includes proper documentation updates
• Contains no breaking changes or security concerns

The changes are straightforward, well-organized, and ready to merge after a successful build verification. Great work on maintaining consistency across a large number of file changes!

---

Files Changed: 45 files (+234 additions, -40 deletions)
Risk Level: Low
Breaking Changes: None