Skip to content

Conversation

@zoeycastillo
Copy link
Contributor

@zoeycastillo zoeycastillo commented Nov 10, 2025

Organizing kb article product folders into categorized sub-folders for 1secure, auditor, data classification, directory manager, endpoint protector, and general. Additionally, added corresponding tags to the kb articles frontmatter.

zoeycastillo and others added 2 commits November 10, 2025 10:36
… KB sections

This commit reorganizes 1,086 KB articles across six product knowledge bases (general, auditor, dataclassification, directorymanager, endpointprotector, and 1secure) into content-based categorized subfolders for improved discoverability and maintainability.

Key changes:
- Auditor KB: 648 articles organized into 7 major categories with 31 subcategories (configuration-and-setup, troubleshooting-and-errors, event-id-reference, system-administration, reports-alerts-and-notifications, monitoring-plans, features-and-operations)
- Directory Manager KB: 125 articles across 9 existing categories verified and organized
- Endpoint Protector KB: 175 articles across 8 categories verified and organized
- Data Classification KB: 42 articles across 6 categories verified and organized
- General KB: Tag format standardization completed for 50+ articles (changed from flow-style to block-style YAML)
- 1Secure KB: 4 articles across 3 categories organized

All files verified: no files remaining at root level, all metadata properly structured.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@zoeycastillo zoeycastillo requested a review from a team as a code owner November 10, 2025 17:18
@zoeycastillo zoeycastillo changed the title Zoey/kbcleaning KB Cleanup and Tag Updates Nov 10, 2025
@claude
Copy link

claude bot commented Nov 10, 2025

Pull Request Review - KB Cleanup and Tag Updates

Overview

This PR reorganizes knowledge base (KB) articles into categorized subdirectories for multiple products (1Secure, Auditor, Data Classification, Directory Manager, Endpoint Protector, and General) and adds corresponding tags to frontmatter metadata.

Scope: 1,087 files changed (+1,286/-610 lines)

Positive Aspects ✅

1. Excellent Organization Structure

The reorganization into categorical subdirectories significantly improves content discoverability:

  • 1Secure: certificate-management, permissions-and-access, troubleshooting
  • Auditor: configuration-and-setup, system-administration, reports-alerts-and-notifications, features-and-operations, event-id-reference
  • Data Classification: system-administration, features-and-operations, migration-and-maintenance, authentication-and-security, troubleshooting-and-errors, term-set-operations
  • Endpoint Protector: content-aware-protection-and-dpi, administration-security-and-monitoring, device-control-and-access-management, enforced-encryption-and-easylock, deployment-and-installation, troubleshooting-and-errors

This categorization aligns well with user mental models and common documentation patterns.

2. Consistent Metadata Enhancement

The addition of tags field to frontmatter supports:

  • Better content filtering and search
  • Improved taxonomy for documentation
  • Enhanced user navigation experience

3. Systematic Approach

The changes follow a consistent pattern across all affected products, demonstrating thorough planning and execution.

Issues and Concerns ⚠️

1. Empty Tags Arrays (Critical)

Many files in the Auditor product have empty tags arrays:

tags: []

Examples:

  • docs/kb/auditor/configuration-and-setup/active-directory-auditing/*.md - All files have tags: []
  • docs/kb/auditor/event-id-reference/health-log-events/*.md - All files have tags: []

Recommendation: Either populate these tags with meaningful category values (e.g., active-directory-auditing, configuration-and-setup, troubleshooting) or remove the empty tags field entirely if they're not yet ready to be used.

2. Inconsistent Tag Naming Conventions

Different products use different tag naming patterns:

  • 1Secure: Uses single-word tags like troubleshooting, certificate-management
  • Data Classification: Uses hyphenated category names like troubleshooting-and-errors, term-set-operations
  • Endpoint Protector: Uses hyphenated category names like troubleshooting-and-errors, device-control-and-access-management

Recommendation: Establish and document a consistent tagging convention. Suggested approach:

  • Use lowercase, hyphenated tags
  • Match the directory structure (e.g., configuration-and-setup, active-directory-auditing)
  • Consider a hierarchical structure: auditor:configuration:active-directory or separate tags: ['auditor', 'configuration', 'active-directory-auditing']

3. File Move Verification Concerns

With 1,087 files changed, there's risk of:

  • Broken internal links between KB articles
  • Broken image references (relative paths)
  • Missing file redirects for external links

Recommendation:

  • Run a link checker to verify all internal links still resolve correctly
  • Check that image paths are still valid after directory restructuring
  • Consider implementing 301 redirects for any URL changes to preserve external links

4. Typos in Frontmatter (Minor)

Found a typo in /docs/kb/1secure/troubleshooting/password-never-expires-report-shows-incorrect-data.md:12,32,36:

Netwrix OneSecutre  # Should be "OneSecure"

5. Missing Documentation

No documentation updates explaining:

  • The new KB article organization structure
  • Tagging guidelines for future contributors
  • Migration guide for users with bookmarked links

Recommendation: Consider adding:

  • A docs/kb/README.md explaining the structure
  • Contributor guidelines for KB article organization
  • A changelog entry documenting this reorganization

Testing Recommendations 🧪

  1. Build Verification

    npm run build

    Ensure the Docusaurus build completes successfully with the new structure.

  2. Link Validation

    • Check for broken internal links using a link checker
    • Verify all image paths resolve correctly
    • Test navigation between related articles
  3. Search Functionality

    • Verify Algolia indexing works with new directory structure
    • Test tag-based filtering (if implemented in UI)
    • Confirm search results link to correct locations
  4. Visual Inspection

    • Spot-check articles from each category
    • Verify frontmatter renders correctly
    • Check sidebar navigation reflects new structure

Security & Performance ✅

  • No security concerns identified - This is purely a content reorganization
  • No performance concerns - File moves don't affect runtime performance
  • No code execution - Only markdown content and metadata changes

Summary Recommendation

Overall Assessment: 👍 Approve with Minor Changes Requested

This PR represents significant improvement to KB article organization. The primary issues are:

  1. Empty tags arrays that should either be populated or removed
  2. Inconsistent tag naming that should be standardized
  3. Need for link verification before merge
  4. Minor typo fixes

Action Items:

  • Populate or remove empty tags: [] entries in Auditor KB articles
  • Establish and document a consistent tag naming convention
  • Run link checker to verify no broken internal links
  • Fix typo: "OneSecutre" → "OneSecure"
  • Consider adding documentation about the new structure

Once these items are addressed, this PR will significantly improve the documentation organization and user experience.


Review generated by Claude Code

@claude
Copy link

claude bot commented Nov 10, 2025

Pull Request Review: KB Cleanup and Tag Updates

Overview

This PR reorganizes knowledge base articles into categorized sub-folders for multiple products (1secure, auditor, data classification, directory manager, endpoint protector, and general) and adds corresponding tags to frontmatter. The scale is significant with 300+ files affected, 1,288 additions and 612 deletions.


✅ Positive Aspects

1. Improved Information Architecture

  • Excellent organizational structure: The new categorization (e.g., 1secure/certificate-management, 1secure/troubleshooting, auditor/configuration-and-setup/active-directory-auditing) creates a logical, intuitive hierarchy
  • Better discoverability: Users will find it easier to locate relevant articles with this structured approach
  • Product-specific organization: Clear separation by product (1secure, auditor, etc.) improves navigation

2. Consistent Frontmatter

From the sampled files, frontmatter appears well-structured with:

  • description fields with clear, concise summaries
  • keywords arrays for SEO and search
  • products arrays for product filtering
  • sidebar_label for navigation
  • knowledge_article_id for tracking
  • tags arrays for categorization

3. Content Quality

The sampled articles show:

  • Clear, professional technical writing
  • Proper markdown formatting
  • Well-structured sections (Overview, Prerequisites, Symptoms, Cause, Resolution)
  • Good use of admonitions (NOTE, IMPORTANT)

🔍 Areas for Review

1. Tag Consistency Concerns

Issue: Some files have empty tag arrays while others have meaningful tags:

  • docs/kb/auditor/configuration-and-setup/active-directory-auditing/active-directory-compression-service-continuously-starting-and-stopping.md has tags: []
  • docs/kb/1secure/certificate-management/configure_proxy_for_rdp_connections_*.md has tags: [certificate-management]
  • docs/kb/1secure/troubleshooting/password-never-expires-report-shows-incorrect-data.md has tags: [troubleshooting]

Recommendation:

  • Review all files with empty tags: [] arrays
  • Add appropriate category tags based on the folder structure (e.g., files in configuration-and-setup should have configuration tags)
  • Create a tagging standard document to ensure consistency across all KB articles

Example: The Active Directory compression service article should have tags like:

tags:
  - active-directory
  - configuration-and-setup
  - troubleshooting

2. Typo in Frontmatter

Issue: In docs/kb/1secure/troubleshooting/password-never-expires-report-shows-incorrect-data.md:

  • Line 3: Netwrix OneSecutre (should be Netwrix OneSecure)
  • Line 12: Netwrix OneSecutre (should be Netwrix OneSecure)

Recommendation: Search for all instances of "OneSecutre" typo and correct to "OneSecure"

3. Sidebar Label Truncation

Issue: In docs/kb/auditor/configuration-and-setup/active-directory-auditing/active-directory-compression-service-continuously-starting-and-stopping.md:

sidebar_label: 'Active Directory Compression Service Continuously '

The label appears truncated (note the trailing space).

Recommendation:

  • Review all sidebar labels for proper truncation
  • Either complete the label or use a more concise version like:
    • 'AD Compression Service Start/Stop Behavior' or
    • 'Active Directory Compression Service Behavior'

4. Scale and Testing Concerns

Questions:

  1. Link integrity: Have all internal links been tested after the reorganization? Moving 300+ files could break many internal references
  2. Build verification: Has the documentation build been tested to ensure all pages render correctly?
  3. Navigation: Have sidebar configurations been updated to reflect the new structure?
  4. Search indexing: Will the search functionality properly index the new locations?

Recommendation:

  • Run link checker across the entire documentation site
  • Verify the build completes without errors
  • Test navigation and search functionality
  • Consider a phased rollout or staging environment verification

5. File Moves vs. New Files

Observation: The PR shows many files with additions: 0, deletions: 0, which might indicate file moves rather than content changes.

Question: Are these files being moved (git mv) or copied? Maintaining git history is important for:

  • Future blame/history tracking
  • Understanding article evolution
  • Preserving author attribution

🎯 Recommendations

High Priority

  1. Fix typo: Correct all "OneSecutre" → "OneSecure" instances
  2. Tag completeness: Add tags to all files currently showing tags: []
  3. Sidebar labels: Fix truncated or incomplete sidebar labels
  4. Link testing: Verify all internal links work after reorganization

Medium Priority

  1. Tagging standards: Create a tagging taxonomy document
  2. Search verification: Test search functionality with new structure
  3. Navigation review: Ensure sidebar navigation reflects new organization

Low Priority

  1. Description consistency: Ensure all descriptions follow similar structure/tone
  2. Keyword optimization: Review keywords for SEO effectiveness

🔒 Security & Performance

No concerns identified - This appears to be purely organizational/metadata changes with no:

  • Code execution
  • External dependencies
  • Performance implications
  • Security vulnerabilities

🧪 Testing Recommendations

  1. Build test: npm run build (or equivalent) should complete without errors
  2. Link check: Run a broken link checker (e.g., linkinator, markdown-link-check)
  3. Search test: Verify search returns expected results for sample queries
  4. Navigation test: Manually verify sidebar navigation works correctly
  5. Typo scan: Run spell checker or search for common misspellings

📊 Summary

Overall Assessment: This is a well-intentioned organizational improvement that will significantly enhance documentation usability. The primary concerns are around:

  • Tag consistency and completeness
  • Typos in content
  • Link integrity verification after the large-scale reorganization

Recommendation: Approve with minor changes - Address the typos and empty tags, then verify links before merging.

Great work on tackling this large organizational effort! The new structure is much more intuitive.

@claude
Copy link

claude bot commented Nov 10, 2025

PR Review: KB Cleanup and Tag Updates

Overview

This PR successfully organizes knowledge base articles into categorized subfolders for multiple products (1Secure, Auditor, Data Classification, Directory Manager, Endpoint Protector, and General) and adds corresponding tags to the frontmatter. The organization significantly improves the structure and maintainability of the KB documentation.

Overall Assessment: ✅ Approved with Minor Issues

Positive Aspects

  1. Excellent Organization: The new folder structure is logical and well-organized:

    • 1Secure: certificate-management, permissions-and-access, troubleshooting
    • Auditor: active-directory-auditing, exchange-auditing, file-server-auditing, general-configuration, microsoft-365-integration, sharepoint-and-teams-auditing, sql-server-auditing, windows-server-monitoring
  2. Consistent Tagging: Tags have been appropriately added to files that needed them (e.g., certificate-management, permissions-and-access, troubleshooting)

  3. Scale: Successfully handles 100 files with 1,290 additions and 614 deletions

  4. Metadata Consistency: Product tags are correctly set (e.g., onesecure, auditor)

Issues Found

🔴 Critical: Typo in Keyword

File: docs/kb/1secure/troubleshooting/password-never-expires-report-shows-incorrect-data.md

  • Line 12: Netwrix OneSecutre should be Netwrix OneSecure
  • Impact: This typo appears in the keywords metadata which may affect search functionality

🟡 Minor: Empty Tags Arrays

Files: Multiple auditor files (e.g., active-directory-object-restore.md)

  • Many auditor files have tags: [] (empty arrays)
  • Recommendation: Consider adding relevant category tags (e.g., active-directory-auditing, configuration-and-setup) to improve searchability and consistency with the 1Secure files

📋 Observation: Missing category.json Files

  • The new subdirectories under docs/kb/1secure/ and docs/kb/auditor/configuration-and-setup/ don't have _category_.json files
  • Impact: May affect navigation/sidebar rendering depending on your Docusaurus configuration
  • Action Required: Verify if these are needed for proper sidebar display

Code Quality Assessment

Markdown Formatting: Proper and consistent
Frontmatter Structure: Correctly formatted with all required fields
File Naming: Follows existing conventions
Path Organization: Logical and scalable
Content Integrity: No content changes that could break links or references

Security Considerations

✅ No security concerns - purely organizational changes

Performance Considerations

✅ No performance impact - file moves don't affect build performance

Test Coverage

⚠️ Recommendation: After merging, verify:

  • All internal links still work correctly
  • Sidebar navigation displays properly
  • Search functionality indexes the new paths
  • No broken image references

Action Items

Before Merge:

  1. Fix the typo: OneSecutreOneSecure in password-never-expires-report-shows-incorrect-data.md

After Merge (optional but recommended):

  1. Consider adding appropriate tags to auditor files with empty tags: [] arrays
  2. Verify if _category_.json files are needed for new subdirectories
  3. Run a link checker to ensure no broken internal references

Great work on this cleanup! The new structure is much more maintainable and will make it easier for users to find relevant KB articles. Just need to fix that one typo before merging.

@claude
Copy link

claude bot commented Nov 10, 2025

Pull Request Review: KB Cleanup and Tag Updates

Overview

This is a large-scale organizational PR affecting 1,087 files with 1,291 additions and 615 deletions. The PR reorganizes knowledge base articles into categorized sub-folders for better structure and adds frontmatter tags for improved discoverability.


Strengths

  1. Well-Structured Organization

    • KB articles are now logically grouped into product-specific folders (1secure, auditor, data classification, directory manager, endpoint protector, general)
    • Sub-categorization (e.g., configuration-and-setup, troubleshooting, permissions-and-access) improves navigation
    • Most files appear to be simple moves (0 additions/0 deletions), minimizing risk of content corruption
  2. Consistent Frontmatter Structure

    • All reviewed files maintain proper YAML frontmatter with required fields:
      • description, keywords, products, sidebar_label, tags, title, knowledge_article_id
    • Good use of multiline descriptions with > for readability
    • Keywords are well-chosen and relevant to content
  3. Tagging Implementation

    • Tags align with folder structure (e.g., troubleshooting, certificate-management, permissions-and-access)
    • Provides metadata for search and filtering capabilities

⚠️ Issues & Concerns

1. Product Name Inconsistency (HIGH PRIORITY)

Some files have inconsistent product naming in frontmatter:

  • File: docs/kb/1secure/certificate-management/configure_proxy_for_rdp_connections_*.md (line 14)

    • Uses: products: - onesecure
    • Should be: products: - 1Secure (based on folder structure and other files)
  • File: docs/kb/1secure/permissions-and-access/how_to_confirm_permissions_*.md (line 14)

    • Also uses: products: - onesecure

Recommendation: Audit all files for consistent product naming. Check if onesecure vs 1Secure vs 1secure matters for your documentation system.

2. Empty Tags Arrays

Several files have empty tags arrays:

  • docs/kb/auditor/configuration-and-setup/active-directory-auditing/active-directory-compression-service-continuously-starting-and-stopping.md (line 17): tags: []
  • docs/kb/auditor/configuration-and-setup/general-configuration/ale-service-is-unable-to-start-during-installation.md (line 17): tags: []

Recommendation: Add appropriate tags based on folder structure and content:

  • First file should have: tags: [configuration-and-setup, active-directory-auditing]
  • Second file should have: tags: [configuration-and-setup, general-configuration]

3. Incomplete Sidebar Labels

  • File: docs/kb/auditor/configuration-and-setup/active-directory-auditing/active-directory-compression-service-continuously-starting-and-stopping.md (line 16)
    • sidebar_label: 'Active Directory Compression Service Continuously ' (trailing space, appears truncated)
    • Should be: sidebar_label: 'Active Directory Compression Service Continuously Starting and Stopping'

4. No Automated Link Updates Verification

With 100+ files moved across directories:

  • Risk: Internal links may be broken if they used relative paths
  • Risk: Image references might be broken
  • Example found: docs/kb/auditor/configuration-and-setup/general-configuration/ale-service-is-unable-to-start-during-installation.md (line 26) references images/ka04u000000HcRH_0EM700000004wmJ.png

Recommendation:

  • Run a broken link checker
  • Verify image paths still resolve correctly
  • Check cross-references between KB articles

🔍 Testing Recommendations

  1. Build Verification

    npm run build

    Ensure the site builds without errors after reorganization

  2. Search Functionality

    • Test that tags are properly indexed
    • Verify search results include reorganized articles
  3. Navigation Testing

    • Manually navigate through new folder structure
    • Verify sidebar generation works correctly
    • Check version selectors (if applicable)
  4. Link Validation

    # Use a tool like markdown-link-check
    find docs/kb -name "*.md" -exec markdown-link-check {} \;
  5. Product Filter Testing

    • Verify products field enables proper filtering
    • Test that inconsistent product names don't break functionality

📋 Action Items

Before Merge:

  • Fix product name inconsistencies (onesecure1secure or 1Secure)
  • Add tags to all files with tags: []
  • Fix truncated sidebar label
  • Run broken link checker
  • Verify image paths
  • Test build locally
  • Spot-check 10-15 files across different products to ensure content intact

Nice to Have:

  • Document the KB organization structure in a README
  • Create a script to validate frontmatter consistency
  • Add CI check for required frontmatter fields

💡 Suggestions for Future

  1. Frontmatter Schema Validation: Consider adding a schema validator to catch inconsistencies automatically
  2. Tag Taxonomy: Document the standard tag values to maintain consistency
  3. Automated Testing: Add CI tests for:
    • Broken links
    • Required frontmatter fields
    • Product name consistency
  4. Migration Guide: If this changes KB URLs, document redirects for SEO

🎯 Overall Assessment

This is a necessary and well-intentioned reorganization that will improve the long-term maintainability of the KB. The structure is logical and the bulk of the work appears clean. However, the issues identified above should be addressed before merge to prevent:

  • User confusion from inconsistent product names
  • Broken search/filtering from empty tags
  • Navigation issues from truncated labels
  • Dead links from file moves

Recommendation: Request changes to fix critical issues, then approve after verification.


Security & Performance Notes

  • ✅ No security concerns identified
  • ✅ No performance issues expected (static content reorganization)
  • ✅ No code execution or build script changes
  • ✅ No test coverage concerns (documentation-only change)

Great work on tackling this large organizational effort! 🚀

@zoeycastillo zoeycastillo merged commit f5e0dca into dev Nov 10, 2025
5 checks passed
@zoeycastillo zoeycastillo deleted the zoey/kbcleaning branch November 10, 2025 21:30
jake-mahon-netwrix added a commit that referenced this pull request Nov 13, 2025
This reverts commit f5e0dca, reversing
changes made to af49132.
jake-mahon-netwrix added a commit that referenced this pull request Nov 13, 2025
This reverts commit f5e0dca, reversing
changes made to af49132.
jake-mahon-netwrix added a commit that referenced this pull request Nov 13, 2025
…zation revert

After reverting the KB folder reorganization (PR #336), 169 KB articles had broken references:
- Image paths using incorrect relative depth (../../images/, ../../../images/)
- Cross-references pointing to non-existent subdirectory paths
- Missing ./ prefix on image paths

Fixed all three patterns:
1. Normalized all image paths to ./images/ format (relative to article location)
2. Removed subdirectories from KB cross-references (/docs/kb/product/file format)
3. Added ./ prefix to bare images/ references

Affected files by product:
- auditor: 51 files
- privilegesecure: 36 files
- accessanalyzer: 30 files
- directorymanager: 14 files
- endpointprotector: 14 files
- dataclassification: 12 files
- threatmanager: 7 files
- threatprevention: 4 files
- 1secure: 2 files
- general: 1 file

All KB articles now use consistent, working reference formats compatible with
the root-level folder structure.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants