-
Notifications
You must be signed in to change notification settings - Fork 29
KB Cleanup and Tag Updates #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… KB sections This commit reorganizes 1,086 KB articles across six product knowledge bases (general, auditor, dataclassification, directorymanager, endpointprotector, and 1secure) into content-based categorized subfolders for improved discoverability and maintainability. Key changes: - Auditor KB: 648 articles organized into 7 major categories with 31 subcategories (configuration-and-setup, troubleshooting-and-errors, event-id-reference, system-administration, reports-alerts-and-notifications, monitoring-plans, features-and-operations) - Directory Manager KB: 125 articles across 9 existing categories verified and organized - Endpoint Protector KB: 175 articles across 8 categories verified and organized - Data Classification KB: 42 articles across 6 categories verified and organized - General KB: Tag format standardization completed for 50+ articles (changed from flow-style to block-style YAML) - 1Secure KB: 4 articles across 3 categories organized All files verified: no files remaining at root level, all metadata properly structured. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Pull Request Review - KB Cleanup and Tag UpdatesOverviewThis PR reorganizes knowledge base (KB) articles into categorized subdirectories for multiple products (1Secure, Auditor, Data Classification, Directory Manager, Endpoint Protector, and General) and adds corresponding tags to frontmatter metadata. Scope: 1,087 files changed (+1,286/-610 lines) Positive Aspects ✅1. Excellent Organization StructureThe reorganization into categorical subdirectories significantly improves content discoverability:
This categorization aligns well with user mental models and common documentation patterns. 2. Consistent Metadata EnhancementThe addition of
3. Systematic ApproachThe changes follow a consistent pattern across all affected products, demonstrating thorough planning and execution. Issues and Concerns
|
Corrected the spelling of '1Secure' in the troubleshooting document.
Pull Request Review: KB Cleanup and Tag UpdatesOverviewThis PR reorganizes knowledge base articles into categorized sub-folders for multiple products (1secure, auditor, data classification, directory manager, endpoint protector, and general) and adds corresponding tags to frontmatter. The scale is significant with 300+ files affected, 1,288 additions and 612 deletions. ✅ Positive Aspects1. Improved Information Architecture
2. Consistent FrontmatterFrom the sampled files, frontmatter appears well-structured with:
3. Content QualityThe sampled articles show:
🔍 Areas for Review1. Tag Consistency ConcernsIssue: Some files have empty tag arrays while others have meaningful tags:
Recommendation:
Example: The Active Directory compression service article should have tags like: tags:
- active-directory
- configuration-and-setup
- troubleshooting2. Typo in FrontmatterIssue: In
Recommendation: Search for all instances of "OneSecutre" typo and correct to "OneSecure" 3. Sidebar Label TruncationIssue: In sidebar_label: 'Active Directory Compression Service Continuously 'The label appears truncated (note the trailing space). Recommendation:
4. Scale and Testing ConcernsQuestions:
Recommendation:
5. File Moves vs. New FilesObservation: The PR shows many files with Question: Are these files being moved (git mv) or copied? Maintaining git history is important for:
🎯 RecommendationsHigh Priority
Medium Priority
Low Priority
🔒 Security & PerformanceNo concerns identified - This appears to be purely organizational/metadata changes with no:
🧪 Testing Recommendations
📊 SummaryOverall Assessment: This is a well-intentioned organizational improvement that will significantly enhance documentation usability. The primary concerns are around:
Recommendation: Approve with minor changes - Address the typos and empty tags, then verify links before merging. Great work on tackling this large organizational effort! The new structure is much more intuitive. |
PR Review: KB Cleanup and Tag UpdatesOverviewThis PR successfully organizes knowledge base articles into categorized subfolders for multiple products (1Secure, Auditor, Data Classification, Directory Manager, Endpoint Protector, and General) and adds corresponding tags to the frontmatter. The organization significantly improves the structure and maintainability of the KB documentation. Overall Assessment: ✅ Approved with Minor Issues Positive Aspects
Issues Found🔴 Critical: Typo in KeywordFile:
🟡 Minor: Empty Tags ArraysFiles: Multiple auditor files (e.g.,
📋 Observation: Missing category.json Files
Code Quality Assessment✅ Markdown Formatting: Proper and consistent Security Considerations✅ No security concerns - purely organizational changes Performance Considerations✅ No performance impact - file moves don't affect build performance Test Coverage
Action ItemsBefore Merge:
After Merge (optional but recommended):
Great work on this cleanup! The new structure is much more maintainable and will make it easier for users to find relevant KB articles. Just need to fix that one typo before merging. |
Pull Request Review: KB Cleanup and Tag UpdatesOverviewThis is a large-scale organizational PR affecting 1,087 files with 1,291 additions and 615 deletions. The PR reorganizes knowledge base articles into categorized sub-folders for better structure and adds frontmatter tags for improved discoverability. ✅ Strengths
|
…zation revert After reverting the KB folder reorganization (PR #336), 169 KB articles had broken references: - Image paths using incorrect relative depth (../../images/, ../../../images/) - Cross-references pointing to non-existent subdirectory paths - Missing ./ prefix on image paths Fixed all three patterns: 1. Normalized all image paths to ./images/ format (relative to article location) 2. Removed subdirectories from KB cross-references (/docs/kb/product/file format) 3. Added ./ prefix to bare images/ references Affected files by product: - auditor: 51 files - privilegesecure: 36 files - accessanalyzer: 30 files - directorymanager: 14 files - endpointprotector: 14 files - dataclassification: 12 files - threatmanager: 7 files - threatprevention: 4 files - 1secure: 2 files - general: 1 file All KB articles now use consistent, working reference formats compatible with the root-level folder structure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Organizing kb article product folders into categorized sub-folders for 1secure, auditor, data classification, directory manager, endpoint protector, and general. Additionally, added corresponding tags to the kb articles frontmatter.