bug/npws-sidebar-build: Sidebar links removed

[florian-berger-netwrix]

Relative sidebar links to older versions of NPWS documentation were removed again, as it looks like they are not working in full builds, whey they are operational in single product builds.

[claude]

Pull Request Review: bug/npws-sidebar-build

Summary

This PR removes the "Older versions" category with manual links to versions 9.1 and 9.2 from the Password Secure 9.3 sidebar configuration. The change simplifies the sidebar to use only the autogenerated structure.

---

✅ Positive Findings

1. Consistency with Codebase Standards

• Good: This change aligns the 9.3 sidebar with the standard pattern used across the repository. After reviewing other sidebar files (privilegesecure, identitymanager, etc.), none of them include manual "Older versions" links.
• Good: The simplified structure matches versions 9.1 and 9.2 which already follow this pattern (sidebars/passwordsecure/9.1.js and 9.2.js).

2. Code Quality

• Good: The resulting code is clean and follows the minimal sidebar configuration pattern.
• Good: Proper trailing comma removed from the autogenerated object, maintaining clean JavaScript syntax.

3. Bug Fix Rationale

• Good: The PR description clearly states the issue: "relative sidebar links to older versions were not working in full builds." This is a valid reason to remove non-functional features.
• Good: Removing broken functionality is better than leaving it in place to confuse users.

---

🔍 Observations & Recommendations

1. Version Switching Mechanism

The repository uses Docusaurus's built-in multi-version support (configured in src/config/products.js). The passwordsecure product has proper version configuration:

versions: [
  { version: '9.3', label: '9.3', isLatest: true, ... },
  { version: '9.2', label: '9.2', isLatest: false, ... },
  { version: '9.1', label: '9.1', isLatest: false, ... }
]

Recommendation: Docusaurus should automatically provide version dropdowns in the UI. Verify that the version switcher is working correctly after this change. If users need to navigate between versions, the Docusaurus version dropdown should handle this better than manual sidebar links.

2. Documentation

Minor suggestion: Consider adding a comment in the commit/PR about why the manual links were originally added and why they're being removed. This helps future maintainers understand the history.

3. Testing Checklist

Before merging, verify:

• Full build completes successfully (npm run build)
• Version switcher dropdown appears on Password Secure docs pages
• Users can navigate between 9.1, 9.2, and 9.3 using the version dropdown
• No broken links or 404 errors when accessing older versions

---

🎯 Final Assessment

Recommendation: ✅ APPROVE

This is a clean, well-justified bug fix that:

• Removes non-functional code
• Aligns with repository conventions
• Simplifies maintenance
• Improves consistency across versions

The change is minimal, low-risk, and addresses a real issue with the full build process.

---

📝 Minor Notes

1. No Security Concerns: This change only affects documentation navigation structure.
2. No Performance Impact: Removing items from the sidebar may marginally improve page load, but impact is negligible.
3. No Test Coverage Needed: This is a configuration file for documentation structure.

Great work on keeping the codebase clean and consistent! 🎉