Skip to content

Conversation

@mithundiddi
Copy link
Member

tested on single camera and stereo cam setup
tested nodes and nodelets
tested with april_tag nodelet in acquisition_nodelet_manager on both x86_64 and arm64(aarch64 jetson tx1)

vik748 and others added 30 commits December 5, 2018 18:29
…transport::camerapublisher and made caminfo to caminfoptr
…to image_transport_test

tested after resolving cnflicts
@mithundiddi mithundiddi requested a review from a user June 12, 2019 05:18
@ghost
Copy link

ghost commented Jun 12, 2019

@mithunvarma does the ReadME need to be updated with these changes? I will do a quick test with the latest and merge it later today or tomorrow.

@mithundiddi
Copy link
Member Author

@shahvi Updated Readme and added launch files for nodelets

@ghost
Copy link

ghost commented Jun 12, 2019

Looks good, couple little suggestions:

  1. Change the acquisition.launch to aquisition_node or aquisition_standalone.launch
  2. Change acquisition_nodelet.launch to acquisition.launch
  3. Change nodelet_test.launch to nodelet_subscriber_example.launch
  4. Turn default behavior for acquisition.launch to launch a nodelet manager.
  5. Add details of configuration for exposure and target grey levels to ReadME (dynamic reconf params)
  6. exposure setting is duplicated in launch file and dynamic reconfigure, fix behavior to only use one of them.

… of launch files, changing dynamic recfg server namespace to fix ns issue for nodelets, nodelet manager starts by default in acquisition.launch
@mithundiddi mithundiddi merged commit 2945642 into master Jun 13, 2019
@mithundiddi mithundiddi deleted the nodelet-imgtransport-feature branch June 13, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants