-
Notifications
You must be signed in to change notification settings - Fork 90
Nodelet imgtransport feature #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transport::camerapublisher and made caminfo to caminfoptr
…to image_transport_test tested after resolving cnflicts
merge image_transport_test branch
|
@mithunvarma does the ReadME need to be updated with these changes? I will do a quick test with the latest and merge it later today or tomorrow. |
…es for nodelets and added example for multiple nodelets
Member
Author
|
@shahvi Updated Readme and added launch files for nodelets |
|
Looks good, couple little suggestions:
|
… of launch files, changing dynamic recfg server namespace to fix ns issue for nodelets, nodelet manager starts by default in acquisition.launch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested on single camera and stereo cam setup
tested nodes and nodelets
tested with april_tag nodelet in acquisition_nodelet_manager on both x86_64 and arm64(aarch64 jetson tx1)