-
Notifications
You must be signed in to change notification settings - Fork 157
Integration Testing for Quantized ONNX export #632
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a good first pass, going to suggest that we refactor the tests into a class that can test parts of the pipeline and pass on (ie apply recipe -> load weights -> export ...)
(see https://docs.pytest.org/en/7.1.x/getting-started.html#group-multiple-tests-in-a-class)
27f868e
to
ebf6ea2
Compare
We do not have yet system in place to catch this error in CI/CD, but this PR will not be complete unless we also merge: |
@dbogunowicz any reason not to use |
@bfineran |
1c5291d
to
da182db
Compare
@dbogunowicz @bfineran Should transformers testing be added to GHA? It seems those tests are getting skipped, as they are a new category not yet included |
* Initial commit * Refactor after Ben's comments * Add testing for weights load and recipe application * Fix style Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
Asana ticket: https://app.asana.com/0/1201735099598270/1201949554543506/f
There are some discrepancies that are probably harmless and expected. For instance, when comparing two pruned models, the sequences of last operations (before logits) differ slightly (this is probably due to how the newer PyTorch version handles the model-->onnx export pipeline).
The prediction head for the original onnx model ("before")

The prediction head for the retrieved onnx model ("after").
