This repository was archived by the owner on Jun 3, 2025. It is now read-only.
[Fix] Reverting back to torch==1.9.0
#686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assing managers as string + add saving functionality to `compose_staged()` Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
dbogunowicz
requested review from
a team,
KSGulin,
anmarques and
bfineran
and removed request for
a team
KSGulin
previously approved these changes
Apr 8, 2022
bfineran
reviewed
Apr 8, 2022
dbogunowicz
commented
Apr 8, 2022
dbogunowicz
commented
Apr 8, 2022
KSGulin
approved these changes
Apr 8, 2022
bfineran
approved these changes
Apr 8, 2022
dbogunowicz
added a commit
that referenced
this pull request
Apr 11, 2022
* [Refactor] BaseManager.compose_staged(): swap `deepcopy` method for passing managers as string + add saving functionality to `compose_staged()` Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * Reverting the last supported version of pytorch to 1.9.0 * Bump torch version from `1.9.0` to `1.9.1` Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com> Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last release, before we knew about the incoming problems with onnx export, I updated the latest supported torch version to
1.10.2(0.11 release). However, we are not yet ready to support it and the sensible thing to do is to rollback, and bring back1.10.Xin release 0.13.Kudos to @KSGulin for catching this. To reproduce the issue, one should grab a switch branch to #632 install fresh dependencies from
setup.py, and run the included transformers integration tests.They will fail, directly because the transformers
exportmethod fails if the torch version is higher than1.9.X.