Skip to content

Conversation

@gaokevin1
Copy link
Contributor

☕️ Reasoning

The links were changed to our OIDC docs, and also you will need to provide a client ID and secret from the environment variables in the definition of the provider. You will also no longer need the Issuer URL as an environment variable.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@gaokevin1 gaokevin1 requested review from 0ubbe and ndom91 as code owners July 12, 2024 17:54
@vercel
Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 6:57pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 6:57pm

@vercel
Copy link

vercel bot commented Jul 12, 2024

@gaokevin1 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@gaokevin1 gaokevin1 changed the title Updated Descope Docs Updated Descope Provider Docs Jul 12, 2024
@ndom91
Copy link
Member

ndom91 commented Jul 21, 2024

Thanks for the update! However, we auto-detect the clientId and clientSecret env vars, so these could all be simplified to:

export const { handlers, auth, signIn, signOut } = NextAuth({
  providers: [ Descope({
      checks: ["pkce", "state"],
    })]
})

Actually, if it always requires those two checks to be passed, I think we'd be better off adding that as a default to the provider directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Refers to `@auth/core` providers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants