Skip to content

fix(InviteesList): change attendee summary logic#7610

Merged
GVodyanov merged 1 commit intomainfrom
fix/change-attendee-summary-logic
Nov 10, 2025
Merged

fix(InviteesList): change attendee summary logic#7610
GVodyanov merged 1 commit intomainfrom
fix/change-attendee-summary-logic

Conversation

@GVodyanov
Copy link
Contributor

@GVodyanov GVodyanov commented Oct 21, 2025

Before After V1 After V2 After V3
swappy-20251021_163840 swappy-20251021_163710 image image

I am right in assuming that an organizer cannot deny the event right?

Also for reference, in both screenshots the event had 1 organizer and 4 invitees

@GVodyanov GVodyanov self-assigned this Oct 21, 2025
@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Oct 21, 2025
@ChristophWurst
Copy link
Member

I still think that "Attendees 5 invited" sounds like invalid grammar, no?

Big 👍 on the 1 vs 2 more attendees line at the bottom

@ChristophWurst
Copy link
Member

I am right in assuming that an organizer cannot deny the event right?

Something @SebastianKrupinski or an RFC study can answer :)

@GVodyanov
Copy link
Contributor Author

image

Looking like this now.

@GVodyanov
Copy link
Contributor Author

@nimishavijay Hey! This change is something me and Christoph discussed, we decided it made more sense to count the organizer as an attendee, do you think that is something that could work or do you have any better ideas? Thanks!

@GVodyanov GVodyanov force-pushed the fix/change-attendee-summary-logic branch from 975d1b5 to 433a82b Compare October 21, 2025 14:48
@ChristophWurst
Copy link
Member

I still think that "Attendees 5 invited" sounds like invalid grammar, no?

@nimishavijay that is the other part where I'd appreciate input :)

@SebastianKrupinski
Copy link
Contributor

SebastianKrupinski commented Oct 21, 2025

Looking like this now.

That looks much better!

As per RFC for ORGANIZER:

(";" cnparam) / (";" dirparam) / (";" sentbyparam) / (";" languageparam) 

The PARTSTATUS parameter is not allowed

As per RFC for ATTENDEE:

(";" cutypeparam) / (";" memberparam) /
(";" roleparam) / (";" partstatparam) /
(";" rsvpparam) / (";" deltoparam) /
(";" delfromparam) / (";" sentbyparam) /
(";" cnparam) / (";" dirparam) /
(";" languageparam) /

The PARTSTATUS is allowed.

So to answer your RFC question, correct the organizer can not decline a event.

Which brings me to the question, why do we set the partstatus on the organizer and handle it on the front end

@SebastianKrupinski
Copy link
Contributor

@nimishavijay Hey! This change is something me and Christoph discussed, we decided it made more sense to count the organizer as an attendee, do you think that is something that could work or do you have any better ideas? Thanks!

This is a matter of human logic vs language.

Technically the organizer is also an attendee as they attend the meeting (language)

But in human thinking terms this might be confusing, as an organizer I think of attendees as who else besides me is attending (human logic)

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.85%. Comparing base (e55535f) to head (f6ca221).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor/Invitees/InviteesList.vue 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7610      +/-   ##
==========================================
- Coverage   10.88%   10.85%   -0.03%     
==========================================
  Files         327      327              
  Lines       62920    63073     +153     
  Branches      902      902              
==========================================
  Hits         6847     6847              
- Misses      55934    56087     +153     
  Partials      139      139              
Flag Coverage Δ
javascript 10.85% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nimishavijay
Copy link
Member

Definitely agreed on the grammar part, I think in the orginal specs the "Attendees" part was supposed to be bold (like a heading) and the rest was suppose to be regular font and text-maxcontrast, so it shouldn't look like one big heading.

As for the wording change, I agree with @SebastianKrupinski that "4 invited" makes sense to the organizer here, but not to anyone else. Maybe the issue is that it says "invited" (because the organizer wouldn't invite themselves). Gcal says "5 guests, 1 yes, 4 awaiting" over 2 lines and this seems pretty clear to me. So maybe we can do

Attendees (5)
1 confirmed, 4 awaiting response 

The number of attendees would be in a counter bubble, and the second line with the response details would be in text-maxcontrast.

@GVodyanov
Copy link
Contributor Author

Here ya go:

image

@nimishavijay
Copy link
Member

Looking great! Small alignment stuff:

  • There can be a little less gap between the "Attendees" and the counter bubble
  • The "1 confirmed, 2 awaiting response" can be aligned with the "Attendees" text

@GVodyanov
Copy link
Contributor Author

image

Here it is now!

@GVodyanov GVodyanov force-pushed the fix/change-attendee-summary-logic branch from 6cb5c0c to f34ca7f Compare November 4, 2025 10:14
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks great now. Only small change I just noticed would look better is to make sure it is a circle when there is a single number (currently stretched to be pill-shaped, assuming because of some sort of min-width). Only that though, so approving to not block :)

@GVodyanov GVodyanov force-pushed the fix/change-attendee-summary-logic branch from f34ca7f to 2648818 Compare November 10, 2025 10:30
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
@GVodyanov GVodyanov force-pushed the fix/change-attendee-summary-logic branch from 2648818 to f6ca221 Compare November 10, 2025 10:33
@GVodyanov GVodyanov merged commit 3e85755 into main Nov 10, 2025
37 of 39 checks passed
@GVodyanov GVodyanov deleted the fix/change-attendee-summary-logic branch November 10, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants