fix(InviteesList): change attendee summary logic#7610
Conversation
|
I still think that "Attendees 5 invited" sounds like invalid grammar, no? Big 👍 on the 1 vs 2 more attendees line at the bottom |
Something @SebastianKrupinski or an RFC study can answer :) |
|
@nimishavijay Hey! This change is something me and Christoph discussed, we decided it made more sense to count the organizer as an attendee, do you think that is something that could work or do you have any better ideas? Thanks! |
975d1b5 to
433a82b
Compare
@nimishavijay that is the other part where I'd appreciate input :) |
That looks much better! As per RFC for ORGANIZER: The PARTSTATUS parameter is not allowed As per RFC for ATTENDEE: The PARTSTATUS is allowed. So to answer your RFC question, correct the organizer can not decline a event. Which brings me to the question, why do we set the partstatus on the organizer and handle it on the front end |
This is a matter of human logic vs language. Technically the organizer is also an attendee as they attend the meeting (language) But in human thinking terms this might be confusing, as an organizer I think of attendees as who else besides me is attending (human logic) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7610 +/- ##
==========================================
- Coverage 10.88% 10.85% -0.03%
==========================================
Files 327 327
Lines 62920 63073 +153
Branches 902 902
==========================================
Hits 6847 6847
- Misses 55934 56087 +153
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Definitely agreed on the grammar part, I think in the orginal specs the "Attendees" part was supposed to be bold (like a heading) and the rest was suppose to be regular font and text-maxcontrast, so it shouldn't look like one big heading. As for the wording change, I agree with @SebastianKrupinski that "4 invited" makes sense to the organizer here, but not to anyone else. Maybe the issue is that it says "invited" (because the organizer wouldn't invite themselves). Gcal says "5 guests, 1 yes, 4 awaiting" over 2 lines and this seems pretty clear to me. So maybe we can do The number of attendees would be in a counter bubble, and the second line with the response details would be in text-maxcontrast. |
|
Looking great! Small alignment stuff:
|
6cb5c0c to
f34ca7f
Compare
nimishavijay
left a comment
There was a problem hiding this comment.
Nice! Looks great now. Only small change I just noticed would look better is to make sure it is a circle when there is a single number (currently stretched to be pill-shaped, assuming because of some sort of min-width). Only that though, so approving to not block :)
f34ca7f to
2648818
Compare
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
2648818 to
f6ca221
Compare



I am right in assuming that an organizer cannot deny the event right?
Also for reference, in both screenshots the event had 1 organizer and 4 invitees