Skip to content

Conversation

@kyteinsky
Copy link
Contributor

No description provided.

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds fallback handling for empty file paths when constructing Source objects. The change ensures that if getInternalPath() returns empty or null, the code will fall back to getPath() and then to getName() as alternatives.

  • Updates Source construction to use a fallback chain for file paths
  • Applies the same pattern consistently across ScanService and IndexerJob

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/Service/ScanService.php Added fallback chain for file path in Source construction
lib/BackgroundJobs/IndexerJob.php Added fallback chain for file path in Source construction

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kyteinsky kyteinsky merged commit f1b8f26 into main Sep 12, 2025
28 of 33 checks passed
@kyteinsky kyteinsky deleted the fix/empty-titles branch September 12, 2025 13:09
@kyteinsky kyteinsky mentioned this pull request Sep 12, 2025
@kyteinsky kyteinsky mentioned this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants