Skip to content

fix: expand the source id regex item part #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

fix: expand the source id regex item part #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions context_chat_backend/chain/ingest/injest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,16 @@ def embed_sources(
f'{source.filename} ({_decode_latin_1(source.headers["title"])})'
for source in sources_filtered
],
'invalid_source_ids': [
source.filename for source in sources
if not is_valid_source_id(source.filename) # pyright: ignore[reportArgumentType]
],
'not_allowed_file_ids': [
source.filename for source in sources
if not _allowed_file(source)
],
'len(source_ids)': len(sources_filtered),
'len(total_source_ids)': len(sources),
})

vectordb = vectordb_loader.load()
Expand Down
3 changes: 2 additions & 1 deletion context_chat_backend/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ def exec_in_proc(group=None, target=None, name=None, args=(), kwargs={}, *, daem


def is_valid_source_id(source_id: str) -> bool:
return re.match(r'^[a-zA-Z0-9_-]+__[a-zA-Z0-9_-]+: \d+$', source_id) is not None
# note the ":" in the item id part
return re.match(r'^[a-zA-Z0-9_-]+__[a-zA-Z0-9_-]+: [a-zA-Z0-9:-]+$', source_id) is not None


def is_valid_provider_id(provider_id: str) -> bool:
Expand Down
Loading