Skip to content

Conversation

@call-me-matt
Copy link
Member

☑️ Resolves

adding some information about picture downloads from social media

🖼️ Screenshots

image

@GVodyanov
Copy link
Contributor

Hey! Thanks a lot for your PR. Could you please amend the commit and sign it off to pass the DCO rules?

@call-me-matt
Copy link
Member Author

Hi. I think I signed it correctly - what exactly is missing for DCO to pass?

@GVodyanov GVodyanov force-pushed the feat/contact-social-avatar branch from 41e311e to da50e20 Compare September 22, 2025 10:34
@GVodyanov
Copy link
Contributor

GVodyanov commented Sep 22, 2025

Hi. I think I signed it correctly - what exactly is missing for DCO to pass?

The issue is that your git email is matthias@pebble, pebble is not a valid email domain

@call-me-matt
Copy link
Member Author

The issue is that your git email is matthias@pebble

This was from the first commit, but I changed that to an existing email. Seems I did not do it correctly, but if I check the commit message of this PR it does not show your quoted faulty email. Could you point me to the place where I missed it?

@GVodyanov
Copy link
Contributor

The issue is that your git email is matthias@pebble

This was from the first commit, but I changed that to an existing email. Seems I did not do it correctly, but if I check the commit message of this PR it does not show your quoted faulty email. Could you point me to the place where I missed it?

I now rebased the two commits into one as that is what we require for merging, to correct the email in the new commit please run:

git commit --amend --author="Matthias <CORRECT EMAIL>" --signoff

and force push. Thanks!

@call-me-matt call-me-matt force-pushed the feat/contact-social-avatar branch from da50e20 to 4eeb8e0 Compare September 23, 2025 19:13
Signed-off-by: Matthias <nextcloud@matthiasheinisch.de>
@GVodyanov GVodyanov force-pushed the feat/contact-social-avatar branch from 675371d to ee0f7c5 Compare September 29, 2025 12:48
@GVodyanov
Copy link
Contributor

Cool cool cool! Let's get this in

@GVodyanov GVodyanov merged commit 3b7a384 into master Sep 29, 2025
13 checks passed
@GVodyanov GVodyanov deleted the feat/contact-social-avatar branch September 29, 2025 12:58
@welcome
Copy link

welcome bot commented Sep 29, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation for the contact app, social media photo download

3 participants