-
Notifications
You must be signed in to change notification settings - Fork 2.3k
add documentation about groupware > contacts > social-avatars #13680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
94d131d to
52e581e
Compare
|
Hey! Thanks a lot for your PR. Could you please amend the commit and sign it off to pass the DCO rules? |
|
Hi. I think I signed it correctly - what exactly is missing for DCO to pass? |
41e311e to
da50e20
Compare
The issue is that your git email is |
This was from the first commit, but I changed that to an existing email. Seems I did not do it correctly, but if I check the commit message of this PR it does not show your quoted faulty email. Could you point me to the place where I missed it? |
I now rebased the two commits into one as that is what we require for merging, to correct the email in the new commit please run:
and force push. Thanks! |
da50e20 to
4eeb8e0
Compare
Signed-off-by: Matthias <nextcloud@matthiasheinisch.de>
675371d to
ee0f7c5
Compare
|
Cool cool cool! Let's get this in |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
☑️ Resolves
adding some information about picture downloads from social media
🖼️ Screenshots