fix: sort user languages by display name #13791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to streamlining the implementation, makes it possible to alphabetize by language display name rather than language code. Signed-off-by: Josh <josh.t.richards@gmail.com>
Key changes: - Removed all rules that modify the template per language (versions-template-all, add-lang-to-versions-template-%). - Retained language detection for multi-language builds. - Assumes language list is passed to the template via Sphinx's conf.py or similar, not injected by Makefile. Signed-off-by: Josh <josh.t.richards@gmail.com>
Automatically detect and list available languages for templates. Mostly so we can sort by display name. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
Looks okay |
nickvergessen
approved these changes
Oct 13, 2025
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Refactors language list building logic, streamlining the code in the template a bit. And builds the language list via a map so we can sort by display name rather than just code.
Did this on my phone so I can't test it, but should be pretty close.
Don't merge until I or one of you is able to confirm still builds + results in the newly expected sorting behavior. :-)
🖼️ Screenshots