Skip to content

Conversation

@hanserasmus
Copy link
Contributor

Please check the formatting, especially the linking to documents. They do not display correctly in my .rst preview, but are done according to examples in the docs.

@michag86
Copy link
Contributor

michag86 commented Aug 28, 2018

I don't know if webtatic repo is a good source:
https://wiki.centos.org/de/AdditionalResources/Repositories/
It is listed under Known Problem Repositories with this comment Provides updated packages with later versions of PHP, MySQL, and other packages. IUS or SCL are better alternatives.

I decided to use software collections (SCL), which is a centos provided repository.
There are Installation guides for php5.6 and php7.0:
#388

Meanwhile software collections also provide php7.1

I don't know if it would be better to extend the manual for updating to php 7.1 from scl?

@hanserasmus
Copy link
Contributor Author

Noted. But I have to make the comment about the package being in a production system currently for more than a year without causing any problems. It is also listed as the preferred repo on another site in their Install walk-through. So imho the CentOS wiki page might be overly conservative? @MorrisJobke can you please advise? Seeing as this will land up on Nextcloud's page? If needed I will have to rewrite it all using SCL, but then it will be PHP 7.1 and not 7.2?

@michag86 Did you maybe still test this walkthrough for any issues regarding the install, irrespective of the Webtatic repo not being the one of choice?

Added additional dependency to extract tar ball.
@hanserasmus
Copy link
Contributor Author

I have run into another issue whilst trying to use SCL, and that is that commands like php -v does not persist after reboots. You have to therefore run scl enable rh-php71 bash everytime. I know symlinking the apache files etc. should suffice for Nextcloud, but if a user wants to troubleshoot their php modules etc, they would have to enable this every time before doing that? I found evidence of this here where they state it is a problem and there are workarounds, but thinking from a sysadmin's perspective, this seems cumbersome and unnecessary. Some input here would be great?
Please note this is a discussion, and not a confrontation by any means. I just think the idea behind a walk through is to get a user up and running as quickly as possible with as little issues as possible. To make the product welcoming basically.

@michag86
Copy link
Contributor

michag86 commented Sep 4, 2018

In our environment we have only installed php from scl. I've just created a symlink /usr/bin/php to the installed binary in the /opt/-path. I don't know if there is a problem with that.

For the moment I had no time to test. Maybe on the weekend.

@jospoortvliet
Copy link
Member

@michag86 had any time to test? The longer it takes for changes to get in the more conflicts one gets and the more work it is to get in 😢

Copy link
Contributor

@michag86 michag86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it on fresh CentOS 7.5 Installation. I have some comments:

  • add "-y" to "yum update"
  • on php installation, here are two packages with extension ".x86_64", where the extension can be removed
  • remove option v for restorecon to reduce unneeded output
  • by default firewalld is active, maybe it's helpful to create a firewall-rule before accessing website?
firewall-cmd --zone=public --add-service=http --permanent
firewall-cmd --reload

the installation wizard will fail, because there is no data folder. Maybe it's helpful to create the folder before chown?
mkdir /var/www/html/nextcloud/data

@hanserasmus
Copy link
Contributor Author

@michag86 Thanks for all the input. I have added all you have suggested. Thanks for the input.

Copy link
Member

@jospoortvliet jospoortvliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Hans, if you could try to resolve the conflicts, we can get this merged! I'll approve it now, it looks good from my POV and I trust you and @michag86 for the technical correctness.

@jospoortvliet
Copy link
Member

Hans - I can resolve the first conflict - - https://www.hanssonit.se/nextcloud-vm/ is correct - but the second requires actual knowledge 😄

@hanserasmus
Copy link
Contributor Author

hanserasmus commented Nov 8, 2018 via email

@hanserasmus
Copy link
Contributor Author

@jospoortvliet I cannot resolve any conflicts, only people with write access can, like yourself. However, not sure why it is conflicting, because I have not even touched those lines. From a technical POV it seems fine, and can be submitted imho.

@jospoortvliet
Copy link
Member

This is the conflict - which part do I keep, top or bottom?

<<<<<<< master

Then create a symlink to :file:`/etc/apache2/sites-enabled`::

  ln -s /etc/apache2/sites-available/nextcloud.conf /etc/apache2/sites-enabled/nextcloud.conf

=======
 
Then enable the newly created site::

  a2ensite nextcloud.conf
 
>>>>>>> master

@hanserasmus
Copy link
Contributor Author

hanserasmus commented Nov 12, 2018 via email

@jospoortvliet jospoortvliet merged commit 09cad63 into nextcloud:master Nov 13, 2018
MorrisJobke pushed a commit that referenced this pull request Nov 13, 2018
* CentOS 7 walkthrough install created

* Update source_installation.rst

Added additional dependency to extract tar ball.

* Added entries from the comment of @michag86
MorrisJobke pushed a commit that referenced this pull request Nov 13, 2018
* CentOS 7 walkthrough install created

* Update source_installation.rst

Added additional dependency to extract tar ball.

* Added entries from the comment of @michag86
@MorrisJobke
Copy link
Member

stable14 b7acc5d
stable13 f8cd27e

@jospoortvliet
Copy link
Member

@MorrisJobke super, thanks for the backports!

@hanserasmus great work dude. @michag86 thanks for reviewing!!!

🎉 🎈 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants