Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Nov 15, 2022

@st3iny
Copy link
Member Author

st3iny commented Nov 15, 2022

/backport to stable25

@st3iny
Copy link
Member Author

st3iny commented Nov 15, 2022

/backport to stable24

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this after nextcloud/all-in-one#1394 is merged and released

Ref nextcloud/previewgenerator#323
Ref nextcloud/server#35105

Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the enh/noid/improve-imaginary-doc branch from a2e0300 to 8c47f86 Compare November 15, 2022 15:17
@szaimen
Copy link
Contributor

szaimen commented Nov 17, 2022

@st3iny should we maybe make somewhere clear that this requires 24.0.8 and 25.0.2 and higher to work?

@st3iny
Copy link
Member Author

st3iny commented Nov 17, 2022

@st3iny should we maybe make somewhere clear that this requires 24.0.8 and 25.0.2 and higher to work?

IMO, that is not necessary. I'd assume that people update to the latest patch release. We should only inform about major version requirements (e.g. a new feature was added in a major version).

@szaimen
Copy link
Contributor

szaimen commented Nov 17, 2022

@st3iny should we maybe make somewhere clear that this requires 24.0.8 and 25.0.2 and higher to work?

IMO, that is not necessary. I'd assume that people update to the latest patch release. We should only inform about major version requirements (e.g. a new feature was added in a major version).

All right then 👍

@szaimen szaimen merged commit 6c2e7cb into master Nov 30, 2022
@szaimen szaimen deleted the enh/noid/improve-imaginary-doc branch November 30, 2022 09:17
@YouveGotMeowxy
Copy link

Is it still recommended to use the image form the screenshot over the official one?

@szaimen
Copy link
Contributor

szaimen commented Apr 27, 2023

Yes, the h2non imaginary image was not updated since 3 years...

@YouveGotMeowxy
Copy link

Yes, the h2non imaginary image was not updated since 3 years...

That's why I was wondering, I haven't looked to far into how many changes have been made int eh last 3 years, but according to this, it was just updated last January?

h2non/imaginary@b632dae

@szaimen
Copy link
Contributor

szaimen commented Apr 28, 2023

It was updated but the docker image not if you look at docker hub.

@YouveGotMeowxy
Copy link

It was updated but the docker image not if you look at docker hub.

Oh, ok. I was just under the impression that Dhub automatically picked up changes on ghub and built the image/kept it updated there as well.

@szaimen
Copy link
Contributor

szaimen commented Apr 28, 2023

was just under the impression that Dhub automatically picked up changes on ghub

Nope

@YouveGotMeowxy
Copy link

Just looked at the list of commits and it looks liek there are many:

https://github.com/h2non/imaginary/commits/master

If I were to use the dockerfile from the official and build it myself, would it be preferred? Just not sure if you guys have done anything to perhaps work specifically more efficiently or anything with NC, and I like to use the so-called latest/greatest updates for everything I use, lol

@szaimen
Copy link
Contributor

szaimen commented Apr 28, 2023

Just use the aio-imaginary container. It is actually built straight from their master and has the latest dependency updates.

@YouveGotMeowxy
Copy link

ok, ty!

@Kraligor
Copy link
Contributor

Kraligor commented Jul 22, 2023

Might want to note that if using the aio Docker container you can't just specify a different port via -p 1234:1234 (as indicated in the Imaginary manual) but need to use 9000.. spent an hour trying to figure out what the issue was lol. Maybe add :9000 to the example too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants