-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Improve documentation around Imaginary #9373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable25 |
|
/backport to stable24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets merge this after nextcloud/all-in-one#1394 is merged and released
Ref nextcloud/previewgenerator#323 Ref nextcloud/server#35105 Co-authored-by: Simon L. <szaimen@e.mail.de> Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
a2e0300 to
8c47f86
Compare
|
@st3iny should we maybe make somewhere clear that this requires 24.0.8 and 25.0.2 and higher to work? |
IMO, that is not necessary. I'd assume that people update to the latest patch release. We should only inform about major version requirements (e.g. a new feature was added in a major version). |
All right then 👍 |
|
Is it still recommended to use the image form the screenshot over the official one? |
|
Yes, the h2non imaginary image was not updated since 3 years... |
That's why I was wondering, I haven't looked to far into how many changes have been made int eh last 3 years, but according to this, it was just updated last January? |
|
It was updated but the docker image not if you look at docker hub. |
Oh, ok. I was just under the impression that Dhub automatically picked up changes on ghub and built the image/kept it updated there as well. |
Nope |
|
Just looked at the list of commits and it looks liek there are many: https://github.com/h2non/imaginary/commits/master If I were to use the dockerfile from the official and build it myself, would it be preferred? Just not sure if you guys have done anything to perhaps work specifically more efficiently or anything with NC, and I like to use the so-called latest/greatest updates for everything I use, lol |
|
Just use the aio-imaginary container. It is actually built straight from their master and has the latest dependency updates. |
|
ok, ty! |
|
Might want to note that if using the aio Docker container you can't just specify a different port via |
Ref nextcloud/previewgenerator#323
Ref nextcloud/server#35105