Fix/lock deletion #897
Merged
Fix/lock deletion #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmart-dev
requested review from
juliusknorr and
max-nextcloud
as code owners
salmart-dev
force-pushed
the
fix/lockDeletion
branch
3 times, most recently
from
53bd388 to
e7063da
Compare
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
This commit fixes an issue with the query logic which prevented locks from being deleted as long as more than one lock is expired. To prevent a potential mass deletion of data due to the fix, the code has been adjusted to delete only 1000 locks at every run of the background job. Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
force-pushed
the
fix/lockDeletion
branch
from
e7063da to
42a75c8
Compare
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue in deleting expired locks, which prevented any expired locks from being deleted as soon as there was more than one expired lock.
The code was building a
DELETE ... WHERE id = # AND id = # AND id = # ...which never deletes any row as long as more than one id is provided.To prevent mass deletion due to the patch for users with many rows in the table, a limit of 1000 rows per-run has been added.