Prevent download, printing and text selection when download is hidden #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable19 |
|
/backport to stable18 |
|
/backport to stable17 |
danxuliu
changed the title
|
Sorry, there is still a missing case (printing through Ctrl+P), please do not review yet :-) |
Even if the Download buttons are hidden in the toolbars it was still possible to trigger the download by using Ctrl|Meta+S. This directly calls the "PDFViewerApplication.download" function, so when downloads are hidden that function is now replaced with an empty function. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Even if the Print button was hidden in the toolbar it was still possible to trigger the printing by using Ctrl|Meta+P. This uses the print service from PDFViewer, so when the download is hidden the print service is now disabled. When printing is flagged as not supported in the PDFViewerApplication initialization the Print buttons are disabled, so it is no longer needed to disable them explicity. Moreover, this also fixes the Print button being disabled only in the toolbar, but not in the secondary toolbar (which is shown in smaller screens). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The Download button is hidden in both the toolbar and the secondary toolbar later, so it is not needed to hide it only for the toolbar first. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Even if printing was not possible using the PDFViewer printing services it was still possible to print the PDF document by printing the web page from the browser. As that can not be really prevented the best that can be done is hide all the content in the printed media using CSS. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When the PDF is rendered PDFViewer creates canvases with the contents of the pages and, in front of them, it creates too a layer with HTML text elements that makes possible to select it. That text layer is used too by the search function to highlight the results, so it can not be removed. Instead of that the selection of the text is prevented using CSS. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
prevent-text-selection-when-download-is-hidden
branch
from
999d885 to
041a36c
Compare
danxuliu
changed the title
|
Ready for review! :-) |
|
Can confirm that these changes work like expected with Nextcloud 18.0.4. |
rullzer
approved these changes
May 15, 2020
juliusknorr
approved these changes
May 15, 2020
This was referenced May 15, 2020
Downloading with Thanks for the information :-) |
|
Sorry, I have not seen your changes to workersrc.js when I accessed this PR first time. Everything is fine now! |
Thanks for the confirmation :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the commit messages for details.
How to test
Results with this pull request
It is not possible to download or print the file, and it is not possible to select the text (of course it is possible to do all that if you know how, but not with the "normal" ways).
Results with this pull request
It is possible to download the file using
Ctrl+S, it is possible to print the file usingCtrl+Por making the window smaller so the Print button appears in the>>menu, it is possible to print the file by printing the full page or the frame from the browser, and it is possible to select the text of the PDF.