Skip to content

Fix download prevent, select override and code cleanup #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2020
Merged

Fix download prevent, select override and code cleanup #199

merged 1 commit into from
Aug 18, 2020

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 17, 2020 •
edited
Loading

  • Refactor utils methods for better coding styling
  • Fixed hide download compliance
  • Fix user-select prevent
  • Upgraded iframe detection deprecated method

@skjnldsv skjnldsv self-assigned this Aug 17, 2020
@skjnldsv skjnldsv added this to the Nextcloud 20 milestone Aug 17, 2020
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 17, 2020

/compile amend /

@skjnldsv skjnldsv requested a review from juliusknorr August 17, 2020 14:38
@skjnldsv @npmbuildbot
Fix download prevent, select override and code cleanup
dbd4cef 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
rullzer
rullzer approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke merged commit 7ac1e71 into master Aug 18, 2020
@MorrisJobke MorrisJobke deleted the fix/various branch August 18, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@danxuliu danxuliu Awaiting requested review from danxuliu

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees

@skjnldsv skjnldsv

Labels

3. to review bug technical debt

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @rullzer @MorrisJobke