-
Notifications
You must be signed in to change notification settings - Fork 288
Update php-stemmer to 4.0 as workaround for full PHP 8.4 compatibility #11566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update php-stemmer to 4.0 as workaround for full PHP 8.4 compatibility #11566
Conversation
…ibility Signed-off-by: David Dreschner <github-2017@dreschner.net>
|
Thanks for opening your first pull request in this repository! ✌️ |
|
Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
|
/backport to stable5.4 |
|
Hey! Question @ChristophWurst @DerDreschner Would this also cover the https://github.com/nextcloud/suspicious_login ? |
|
@AndyXheli : It could, depending on which version requirement is being load first. But it shouldn't. I've opened a separate pull request for that issue there: nextcloud/suspicious_login#1027 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
see nextcloud/mail#11566 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
As discussed over in the suspicious_login repository,
php-stemmeris a dependency of RubixML. They currently point to the version 3.0 ofphp-stemmer, which isn't fully compatible with PHP 8.4 due to a dependency onportable-utf8. This issue is already handled by the maintainers ofphp-stemmerby releasing the version 4.0, which replacedportable-utf8withjoomla/string. This isn't a breaking change, so, the version bump was done just in case.Until RubixML uses the latest version (see RubixML/ML#359), we can deploy a workaround and use
php-stemmer4.0 by using it as alias for version 3.0.This fixes #11137.