Skip to content

Conversation

@DerDreschner
Copy link
Contributor

As discussed over in the suspicious_login repository, php-stemmer is a dependency of RubixML. They currently point to the version 3.0 of php-stemmer, which isn't fully compatible with PHP 8.4 due to a dependency on portable-utf8. This issue is already handled by the maintainers of php-stemmer by releasing the version 4.0, which replaced portable-utf8 with joomla/string. This isn't a breaking change, so, the version bump was done just in case.

Until RubixML uses the latest version (see RubixML/ML#359), we can deploy a workaround and use php-stemmer 4.0 by using it as alias for version 3.0.

This fixes #11137.

…ibility

Signed-off-by: David Dreschner <github-2017@dreschner.net>
@welcome
Copy link

welcome bot commented Aug 22, 2025

Thanks for opening your first pull request in this repository! ✌️

@ChristophWurst
Copy link
Member

Thanks a lot!

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ChristophWurst
Copy link
Member

/backport to stable5.4

@ChristophWurst ChristophWurst merged commit 0b7e9f1 into nextcloud:main Sep 2, 2025
39 checks passed
@AndyXheli
Copy link

AndyXheli commented Sep 2, 2025

Hey! Question @ChristophWurst @DerDreschner Would this also cover the https://github.com/nextcloud/suspicious_login ?

voku\helper\UTF8::reduce_string_array(): Implicitly marking parameter $remove_short_values as nullable is deprecated, the explicit nullable type must be used instead at /var/www/nextcloud/apps/suspicious_login/vendor/voku/portable-utf8/src/voku/helper/UTF8.php#13827

@DerDreschner
Copy link
Contributor Author

@AndyXheli : It could, depending on which version requirement is being load first. But it shouldn't. I've opened a separate pull request for that issue there: nextcloud/suspicious_login#1027

@DerDreschner DerDreschner deleted the fix/11137-update-rubixml-dependency branch September 4, 2025 04:51
@github-actions
Copy link

github-actions bot commented Sep 6, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

marcelklehr added a commit to nextcloud/recognize that referenced this pull request Sep 24, 2025
see nextcloud/mail#11566

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP8.4 "voku\helper\UTF8::reduce_string_array(): Implicitly marking parameter $remove_short_values as nullable is deprecated"

3 participants