fix(search): apply correct search query when fetching envelopes #12062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/11629/apply-search-query
branch
from
da5f690 to
e3394d1
Compare
Contributor
Author
It looks like an oversight. For singleton, I assume we should also fetch the next page with singleton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11629
6e7b529
searchQueryis only mutated when entering a search term.To apply
is:starred(depending on the route), one must use the computed query property.6c788ce
I noticed while testing that the view mode is not applied in fetchNextEnvelopes. Will do some more testing if that's on purpose or not.
Test cases:
The expected outcome is to see
?filterfor all requests with the right value.