Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search-filter for notes list doesn't use the notes' contents #288

Open
korelstar opened this issue Jan 6, 2019 · 0 comments

Comments

@korelstar
Copy link
Member

commented Jan 6, 2019

Due to the speed optimization in #233, the content of the notes is not loaded anymore when loading the notes list. This is still a good decision, but as a consequence filtering notes using a keyword (resp. search string) doesn't "search" in the notes' contents - since filtering is performed on the client. Currently, filtering uses metadata such as the note's title, path, and category, only.

In order to (re-)introduce filtering by notes' contents, we have to implement a server-side search. Of course, the search should be performed asynchronously and has to cope with network errors, users who type faster than the network connection etc. (you know that stuff).


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.