-
Notifications
You must be signed in to change notification settings - Fork 64
Send a push message when a notification was deleted #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send a push message when a notification was deleted #318
Conversation
c684b7d to
ecfeb67
Compare
|
@skjnldsv mind to help? |
|
@nickvergessen what you see is not the notifications app, the script is not even on the page for me :) |
|
Did you checkout nextcloud/server#15040 on the server too? |
|
@nickvergessen right, I did not. The get requests return an empty response for notifications |
ecfeb67 to
1cb3553
Compare
|
When I remove a notification in web ui, I do receive this in android app: I can then succesfully remove associated notification 343 from status bar. |
|
https://github.com/nextcloud/notifications/pull/318/files#diff-1383a847921c5d9a7163f3de431d5165R301 there are new parameters Type and ID refer to an object, so abusing them is not a good idea. |
Ah, great.
Never wanted to do this :-) |
|
|
|
Android part is in: nextcloud/android#3969 |
|
@nickvergessen What is the status here? We are close to the beta 1. Should this go into 17 or 18? |
|
Still on track and planned for today+tomorrow |
1cb3553 to
b833ed9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and works 👍
4848c3c to
d8452e4
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
f4c8ff1 to
7a18325
Compare

Fix #285
Fix #250
Server requirement: nextcloud/server#15040