Skip to content

Conversation

@sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Apr 30, 2025

conversation_subline

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch self-assigned this Apr 30, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Apr 30, 2025
@nickvergessen
Copy link
Member

Can you add screenshots of all the cases?
Shared contact, poll, image, file, …

@sowjanyakch sowjanyakch force-pushed the attachment_attachment branch from 86cf59d to a9f0243 Compare May 12, 2025 10:16
@nickvergessen
Copy link
Member

Do you also show the caption if there is one? Or only the file name?

@sowjanyakch
Copy link
Contributor Author

For attachments, caption is shown if it's available otherwise file name is shown.

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@mahibi mahibi force-pushed the attachment_attachment branch from a9f0243 to f29793b Compare May 14, 2025 16:09
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4940-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9992
Errors1010

SpotBugs

CategoryBaseNew
Bad practice66
Correctness22216
Dodgy code7167
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310100

@mahibi mahibi merged commit e920a79 into master May 14, 2025
17 checks passed
@mahibi mahibi deleted the attachment_attachment branch May 14, 2025 16:42
@mahibi mahibi added this to the 21.1.0 milestone May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve subline when last message is attachment with caption

4 participants