Skip to content

Message Pinning 📌 #5535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Message Pinning 📌 #5535

wants to merge 2 commits into from

Conversation

@rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Nov 4, 2025 •
edited
Loading

The CI/CD Analysis check seems to be broken

Screenshot 2025-11-17 at 10 22 57 AM

🚧 TODO

  • Data Classes
  • Mappers
  • Api
  • Repository
  • ViewModel
  • UI
    • Capabilities Check
    • Message actions + callback
    • Pin/unPin from message actions
    • Pinned View must not conflict with out of office view
    • Pinned Hide/unPin functionality
    • Dialog pin24h, pin7d, pin30d, pinIndefinitely, pinCustom
    • Improve UI
    • Update UI from conversation flow
    • Add new system message for pinned
    • Pinned at/by (need to get the msg from the server)
    • Editing a pinned message reflects changes to pin?
    • Check Scrollable for longer messages
    • Check Shared Objects/files

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Nov 4, 2025
@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Nov 4, 2025
@rapterjet2004 rapterjet2004 marked this pull request as ready for review November 17, 2025 16:15
@rapterjet2004
Added Pinned Messages Support
9a043b0 
- ChatMessage now has ChatMessageMetaData
- Conversation now has updated fields from server
- Added PinnedMessageOptionsDialog
- API, viewmodel, class functions

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 force-pushed the issue-5534-message-pinning branch from 32d678e to 9a043b0 Compare November 19, 2025 13:36
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 21, 2025
@rapterjet2004
hardening code in case of error
27d4daa 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5535.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi Awaiting requested review from mahibi

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

At least 1 approving review is required to merge this pull request.

Assignees

@rapterjet2004 rapterjet2004

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Message Pinning 📌

2 participants

@rapterjet2004