fix: do not use removed View::getLocalFolder() #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually without replacement. Prior to NC 27 it was implemented on local storage only, trying to run it would have led into an Exception – if folders were not filtered out here already. Since the method would actually only make sense for external folders, removing it seems to be the reasonable decision, and actually does not remove functionality. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
|
/backport to stable27 |
come-nc
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually without replacement. Prior to NC 27 it was implemented on local storage only, trying to run it would have led into an Exception – if folders were not filtered out here already. Since the method would actually only make sense for external folders, removing it seems to be the reasonable decision, and actually does not remove functionality.
fixes #171
obsoletes #174