-
Notifications
You must be signed in to change notification settings - Fork 2
feat: embedded help command #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: embedded help command #4
Conversation
MaskDuck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my ancestor told me that others are fine
|
The init file for the module should be updated so that this can be imported directly from nextcord.ext.help_commands |
|
This is completely up to you since it's your help command design, but I'm thinking maybe cog help should show cog and command descriptions (command.short_doc)? The first bot is what I currently use and the same as paginated.py in this lib and the Test bot is using yours. I'm also noticing it does not have markdown support (or any descriptions having backticks). This is also fine if intended, but also something you may want to consider. Additionally, I think this title is a bit long. Maybe the Feel free to take ideas from mine or leave things as is if you prefer. |
The problem is, what if there are many commands? Both solutions are pretty valid but I think for cogs that have more than a couple commands, the way I do it is better. And actually, as this is no longer limited by the "the lib shouldn't do your work" part, I might as well give the current implementation a full redesign, my personal bot which I use with my friends has this command but way more upgraded, I will get to work on that and commit tonight / tomorrow. |
fix: remove useless f-string refactor: minor rewording fix: use clean_prefix instead of prefix
|
This bot.help_command = EmbeddedHelpCommand(main_embed_color=0x0000ff, main_embed_title="Main Help", main_embed_description="This is the help overview",
command_embed_color=0x00ff00, command_embed_description="Command embed description", command_embed_title="Command embed title",
group_embed_color=0x00ffff, group_embed_description="Group embed description", group_embed_title="Group embed title",
cog_embed_color=0xff0000, cog_embed_description="Cog embed description", cog_embed_title="Cog embed title",
dm_only=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested but lgtm
Co-authored-by: MaskDuck <it-is@too-obvious-that.maskduck.is-a.dev>
Co-authored-by: MaskDuck <it-is@too-obvious-that.maskduck.is-a.dev>
…dded_help_command
Co-authored-by: teaishealthy <76410798+teaishealthy@users.noreply.github.com>
|
Thanks for your patience. I think I'll merge it for now. The repo can always be enhanced and updated in the future. 👍 |







Summary
Add embedded help command from nextcord#701
Checklist
task pyrightand fixed the relevant issues.