This repository was archived by the owner on Dec 9, 2024. It is now read-only.
fix: remove default handlers for write actions in NeynarFeedCard and in NeynarCastCard reactions
#26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kevoconnell
reviewed
Aug 20, 2024
Comment on lines
-11
to
-14
| import { NeynarFrameCard, NeynarFrame as NeynarFrameCardType } from "../organisms/NeynarFrameCard"; | ||
|
|
||
| type NeynarFrame = { | ||
| image: string; |
kevoconnell
reviewed
Aug 20, 2024
Contributor
kevoconnell
left a comment
kevoconnell
left a comment
There was a problem hiding this comment.
TBH i don't have enough context to approve but generally speaking looks good
not present in all frames and not displayed in the `NeynarFrameCard` UI
manan19
approved these changes
Aug 20, 2024
manan19
approved these changes
Aug 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix ensures that any default handlers for SDK write actions are removed and replaced with override-able props to ensure that any write actions are handled on the developer's end and in a secure manner.