Prepare release 2.0.0 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix broken link
Merging template updates 2.1
Co-authored-by: Alexander Peltzer <apeltzer@users.noreply.github.com>
prepare release
apeltzer
approved these changes
Aug 27, 2021
| @@ -0,0 +1,50 @@ | |||
| // Import generic module functions | |||
There was a problem hiding this comment.
Might be a candidate for nf-core/modules ;-)
There was a problem hiding this comment.
Postponed, see #61
| @@ -0,0 +1,36 @@ | |||
| // Import generic module functions | |||
There was a problem hiding this comment.
Postponed, see #61
| @@ -0,0 +1,43 @@ | |||
| // Import generic module functions | |||
There was a problem hiding this comment.
Postponed, see #61
| @@ -0,0 +1,41 @@ | |||
| // Import generic module functions | |||
There was a problem hiding this comment.
Postponed, see #61
| @@ -0,0 +1,41 @@ | |||
| // Import generic module functions | |||
There was a problem hiding this comment.
Postponed, see #61
| @@ -0,0 +1,41 @@ | |||
| // Import generic module functions | |||
There was a problem hiding this comment.
Postponed, see #61
| @@ -0,0 +1,50 @@ | |||
| // Import generic module functions | |||
There was a problem hiding this comment.
Postponed, see #61
| @@ -0,0 +1,34 @@ | |||
| // Import generic module functions | |||
There was a problem hiding this comment.
Postponed, see #61
| @@ -0,0 +1,52 @@ | |||
| // Import generic module functions | |||
There was a problem hiding this comment.
Postponed, see #61
workflows/bacass.nf
Outdated
| ch_software_versions = ch_software_versions.mix(FASTQC.out.version.first().ifEmpty(null)) | ||
|
|
||
| // | ||
| // MODULE: Skewer, trim and combine short read read-pairs per sample. Similar to nf-core vipr |
There was a problem hiding this comment.
Suggested change
| // MODULE: Skewer, trim and combine short read read-pairs per sample. Similar to nf-core vipr | |
| // MODULE: Skewer, trim and combine short read read-pairs per sample. |
That pipeline has never surfaced ;-)
There was a problem hiding this comment.
Thanks! I cannot commit this suggestion because I have no write-right on dev. I will need to commit this in a PR to dev if you do not want/can commit it yourself.
There was a problem hiding this comment.
Opened PR to dev, please see #60
ggabernet
approved these changes
Aug 27, 2021
README.md
Outdated
|
|
||
| ## Credits | ||
|
|
||
| nf-core/bacass was originally written by Andreas Wilm, Alexander Peltzer. | ||
| nf-core/bacass was initiated by [Andreas Wilm](https://github.com/andreas-wilm), originally written by [Alex Peltzer](https://github.com/apeltzer) (DSLv1) and rewritten by [Daniel Straub](https://github.com/d4straub) (DSLv2). |
There was a problem hiding this comment.
Suggested change
| nf-core/bacass was initiated by [Andreas Wilm](https://github.com/andreas-wilm), originally written by [Alex Peltzer](https://github.com/apeltzer) (DSLv1) and rewritten by [Daniel Straub](https://github.com/d4straub) (DSLv2). | |
| nf-core/bacass was initiated by [Andreas Wilm](https://github.com/andreas-wilm), originally written by [Alex Peltzer](https://github.com/apeltzer) (DSLv1) and rewritten by [Daniel Straub](https://github.com/d4straub) (DSL2). |
There was a problem hiding this comment.
Thanks! Should I than also change from DSLv1 to DSL1 ?
There was a problem hiding this comment.
I cannot commit this suggestion because I have no write-right on dev. I will need to commit this in a PR to dev if you do not want/can commit it yourself.
There was a problem hiding this comment.
Opened PR to dev, please see #60
resolve reviewer comments
|
Good to go - you may release ;-) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of release 2.0.0. Mainly template update, conversion to DSL2 and software updates. Details in the CHANGELOG.
FYI, running on AWS with nextflow tower using github actions metagtests succeeded.
PR checklist
CHANGELOG.mdis updateddocsis updated