Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

Propagate peptide ksize to sencha translate #83

Merged
merged 5 commits into from
May 27, 2020

Conversation

olgabot
Copy link
Collaborator

@olgabot olgabot commented May 23, 2020

Many thanks to contributing to nf-core/kmermaid!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • PR is to dev rather than master
  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • CHANGELOG.md is updated

Learn more about contributing: https://github.com/nf-core/kmermaid/tree/master/.github/CONTRIBUTING.md

@pranathivemuri
Copy link
Contributor

good catch, thanks! :)

@pranathivemuri
Copy link
Contributor

@olgabot resolved merge conflicts, please merge when you are free!

@pranathivemuri
Copy link
Contributor

there is some randomness in the tests failing with test_fastas config

@olgabot olgabot merged commit 6282be8 into dev May 27, 2020
@ewels ewels deleted the olgabot/propagate-peptide-ksize branch October 22, 2020 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants