Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

sourmash compute nucleotide was getting skipped but not peptide - fix the logic for it #87

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

pranathivemuri
Copy link
Contributor

Many thanks to contributing to nf-core/kmermaid!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • PR is to dev rather than master
  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/kmermaid branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/kmermaid/tree/master/.github/CONTRIBUTING.md

@pranathivemuri pranathivemuri added the reviewer can merge PR can be approved & merged by the reviewer label Jun 25, 2020
@pranathivemuri
Copy link
Contributor Author

@olgabot could you please review this PR?

1 similar comment
@pranathivemuri
Copy link
Contributor Author

@olgabot could you please review this PR?

@olgabot
Copy link
Collaborator

olgabot commented Jul 7, 2020

Thanks for the ping!

@pranathivemuri
Copy link
Contributor Author

@olgabot since the markdown bits don't completely pass, I can't merge. if you have the rights to merge, could you please?

@olgabot olgabot merged commit 3878b08 into dev Jul 7, 2020
@ewels ewels deleted the pranathi-skipc branch October 22, 2020 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
reviewer can merge PR can be approved & merged by the reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants