Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change installation of software + add testing for singularity #32

Closed
wants to merge 1 commit into from
Closed

Change installation of software + add testing for singularity #32

wants to merge 1 commit into from

Conversation

maxulysse
Copy link
Member

As discussed in #30
I had to undo some changes to install Singularity only when needed, but I tried to improve them as well ;-)

@maxulysse maxulysse requested review from ewels and a team June 14, 2018 17:44
@maxulysse
Copy link
Member Author

By the way tests are of course working (at least on my fork)

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I like testing Singularity too, but agree with @ewels that it shouldn't really break since we're always using conda for both singularity and docker anyways. Still nice to test things!

@ewels
Copy link
Member

ewels commented Jun 15, 2018

What do you guys think about adding a subcommand to nf-core tools to install stuff? Maybe it’s overkill, but I was just thinking that it would avoid having to add scripts like this to every pipeline (and give a single location to update).

Could even be clever and auto-detect platform and stuff. Or just bail if not Linux.

@apeltzer
Copy link
Member

Love that idea! Yes, that should keep our pipelines clean from install.sh scripts ;-) And Sarek might be able to use that too ;-)

@ewels ewels added the on hold label Jun 27, 2018
@ewels ewels changed the base branch from master to dev August 13, 2018 12:10
@ewels ewels added WIP Work in progress and removed on hold labels Aug 20, 2018
@ewels
Copy link
Member

ewels commented Oct 5, 2018

Closing this now, as we will build functionality into nf-core tools if anything.

@ewels ewels closed this Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants