Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release 2.5.1 #53

Merged
merged 23 commits into from
Oct 22, 2019
Merged

Prepare release 2.5.1 #53

merged 23 commits into from
Oct 22, 2019

Conversation

maxulysse
Copy link
Member

Fixes and closes #48 #49 #50

Many thanks to contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: guidelines

@maxulysse maxulysse added the release This PR is for a release label Oct 21, 2019
@maxulysse maxulysse self-assigned this Oct 21, 2019
@maxulysse maxulysse requested review from apeltzer and a team October 21, 2019 14:59
@maxulysse maxulysse mentioned this pull request Oct 22, 2019
Closed
drpatelh
drpatelh approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@maxulysse maxulysse mentioned this pull request Oct 22, 2019
Merged
5 tasks
@maxulysse maxulysse merged commit 05c6e0b into nf-core:master Oct 22, 2019
@maxulysse maxulysse deleted the patch branch October 28, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

@apeltzer apeltzer apeltzer approved these changes

Assignees

@maxulysse maxulysse

Labels
release This PR is for a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add singularity.autoMounts = true to config or put autoMounts = true in scope
3 participants
@maxulysse @apeltzer @drpatelh