Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all modules, fix template points #201

Merged
merged 7 commits into from
Mar 5, 2023
Merged

Update all modules, fix template points #201

merged 7 commits into from
Mar 5, 2023

Conversation

apeltzer
Copy link
Member

@apeltzer apeltzer commented Feb 28, 2023 •
edited by klkeys
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Feb 28, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit f4f7a62

+| ✅ 158 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-05 18:07:58

@apeltzer apeltzer enabled auto-merge March 1, 2023 14:50
FriederikeHanssen
FriederikeHanssen reviewed Mar 1, 2023
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
grst
grst approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-added the conda.enabled lines.

Rest looks good!

@apeltzer apeltzer merged commit f8ef18c into dev Mar 5, 2023
@apeltzer apeltzer deleted the update-and-fix branch March 5, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkeys klkeys klkeys left review comments

@FriederikeHanssen FriederikeHanssen FriederikeHanssen left review comments

@grst grst grst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apeltzer @grst @FriederikeHanssen @klkeys