-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template: Better handling of params.fasta
requirement
#2289
Comments
I put it in Think I added I would prefer (1) because you can quite easily search for the error code in VS code and find where it is. (2) would be good either way. |
…n.initialise() Changes: - Guts WorkflowMain, particularly the initialise() method - Replaces it with INIITIALISE subworkflow - Should be easier to maintain via nf-core/modules (more regular updates) - Uses more native Nextflow for bioinformatics developers to follow Should incidentally fix nf-core#2289
…n.initialise() Changes: - Guts WorkflowMain, particularly the initialise() method - Replaces it with INIITIALISE subworkflow - Should be easier to maintain via nf-core/modules (more regular updates) - Uses more native Nextflow for bioinformatics developers to follow Should incidentally fix nf-core#2289
|
Description of feature
We currently have a check for
params.fasta
hardcoded intolib/WorkflowPipeline.groovy
:tools/nf_core/pipeline-template/lib/WorkflowPipeline.groovy
Lines 18 to 20 in 0912990
This is not very easy to find and tricky for people creating non-genomics pipelines.
Needs one or more of the following:
// TODO nf-core:
comment to flag it for review withnf-core lint
lib
to somewhere more visible? 🤔 eg. we already have similar checks here:tools/nf_core/pipeline-template/workflows/pipeline.nf
Lines 17 to 18 in 0912990
My preference would be (3) unless there's a specific reason for having it where it is currently.. @drpatelh ?
The text was updated successfully, but these errors were encountered: