-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to recognise and download SRA/ENA/GEO ids #68
Conversation
Might you be able to add a commit with this usage.md doc patch to this pr?
|
Done 53b5e86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very nice @drpatelh !
The only thing that I would suggest is that if we want to completely get rid of the parallel-fastq-dump
process, we could eventually query the US DB when the ftp is not available at the EBI, as we did before ( https://github.com/JoseEspinosa/viralrecon/blob/460a29f962edc31d7818d63b26b6fad5b98d0cbc/bin/check_samplesheet.py#L34-L35 ). One of the fields returned by the query was download_path
. We could use this path to download the data using process SRA_FASTQ_FTP
. The only problem could be how to retrieve the md5 checksums
since this information is not returned by the query and I was trying to find a way to get it from the NCBI but I couldn't find a way yet.
Thanks @JoseEspinosa Querying the NCBI for the fastq files if they dont exist in the ENA doesnt work for this sample 😏 It returns a path to the |
nf-core/viralrecon pull request
Many thanks for contributing to nf-core/viralrecon!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: CONTRIBUTING.md